Tests

Require redemption throttle limits above issuance throttle limits #3924

Triggered via pull request September 19, 2024 05:00

pmckelvy1

opened #1209

red-throttle-limits

Status Failure

Total duration 38m 2s

Artifacts –

tests.yml

on: pull_request

Plugin Integration Tests (Mainnet) - 1/2

37m 48s

Plugin Integration Tests (Mainnet) - 2/2

20m 18s

Plugin Integration Tests (Base)

6m 40s

Plugin Integration Tests (Arbitrum)

Monitor Tests (Mainnet)

2m 1s

Annotations

17 errors and 23 warnings

Lint Checks: contracts/interfaces/IRToken.sol#L146

Delete ····

Lint Checks: contracts/p1/RToken.sol#L499

Line length must be no more than 100 but current length is 109

Lint Checks: contracts/p1/RToken.sol#L500

Line length must be no more than 100 but current length is 110

Lint Checks: contracts/p1/RToken.sol#L503

Line length must be no more than 100 but current length is 107

Lint Checks: contracts/p1/RToken.sol#L508

Replace ·(issuance.amtRate·*·MIN_THROTTLE_DELTA with ⏎············((issuance.amtRate·*·MIN_THROTTLE_DELTA)

Lint Checks: contracts/p1/RToken.sol#L509

Replace ·(issuance.pctRate·*·MIN_THROTTLE_DELTA with ⏎············((issuance.pctRate·*·MIN_THROTTLE_DELTA)

Lint Checks: contracts/p1/RToken.sol#L510

Delete ········

Lint Checks

Process completed with exit code 123.

Monitor Tests (Mainnet)

Process completed with exit code 1.

Integration Tests

Process completed with exit code 2.

Plugin Integration Tests (Base)

Process completed with exit code 5.

Plugin Integration Tests (Arbitrum)

Process completed with exit code 6.

P1 Tests

Process completed with exit code 3.

P0 tests

Process completed with exit code 6.

Plugin Integration Tests (Mainnet) - 2/2

Process completed with exit code 22.

Extreme Tests

Process completed with exit code 109.

Plugin Integration Tests (Mainnet) - 1/2

Process completed with exit code 17.

Lint Checks

The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-node@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/

Lint Checks: contracts/facade/Facade.sol#L30

When fallback is not payable you will not be able to receive ether

Lint Checks: contracts/facade/Facade.sol#L30

Fallback function must be simple

Lint Checks: contracts/facade/Facade.sol#L35

Avoid to use inline assembly. It is acceptable only in rare cases

Lint Checks: contracts/facade/facets/RevenueFacet.sol#L47