fix based on comments

reserve-protocol · Aug 19, 2024 · 6cd751c · 6cd751c
1 parent 8e28178
commit 6cd751c
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/scripts/deployment/phase2-assets/collaterals/deploy_cbeth_collateral.ts b/scripts/deployment/phase2-assets/collaterals/deploy_cbeth_collateral.ts
@@ -53,8 +53,8 @@ async function main() {
       'CBEthCollateral'
     )) as CBEthCollateral__factory
 
-    const CBETH_ORACLE_ERROR = fp('0.02') // 2%
-    const oracleError = combinedError(fp('0.005'), CBETH_ORACLE_ERROR) // 0.5% & 2%
+    const CBETH_ORACLE_ERROR = fp('0.01') // 1%
+    const oracleError = combinedError(fp('0.005'), CBETH_ORACLE_ERROR) // 0.5% & 1%
 
     collateral = await CBETHCollateralFactory.connect(deployer).deploy(
       {
@@ -65,7 +65,7 @@ async function main() {
         maxTradeVolume: fp('1e6').toString(), // $1m,
         oracleTimeout: '3600', // 1 hr,
         targetName: hre.ethers.utils.formatBytes32String('ETH'),
-        defaultThreshold: fp('0.02').add(CBETH_ORACLE_ERROR).toString(), // 4%
+        defaultThreshold: fp('0.02').add(CBETH_ORACLE_ERROR).toString(), // 3%
         delayUntilDefault: bn('86400').toString(), // 24h
       },
       fp('1e-4').toString(), // revenueHiding = 0.01%

diff --git a/scripts/verification/collateral-plugins/verify_cbeth.ts b/scripts/verification/collateral-plugins/verify_cbeth.ts
@@ -26,9 +26,9 @@ async function main() {
   deployments = <IAssetCollDeployments>getDeploymentFile(assetCollDeploymentFilename)
 
   /********  Verify Coinbase staked ETH - CBETH  **************************/
-  const CBETH_ORACLE_ERROR = fp('0.02')
   if (!baseL2Chains.includes(hre.network.name)) {
-    const oracleError = combinedError(fp('0.005'), CBETH_ORACLE_ERROR) // 0.5% & 2%
+    const CBETH_ORACLE_ERROR = fp('0.01')
+    const oracleError = combinedError(fp('0.005'), CBETH_ORACLE_ERROR) // 0.5% & 1%
 
     await verifyContract(
       chainId,
@@ -42,7 +42,7 @@ async function main() {
           maxTradeVolume: fp('1e6').toString(), // $1m,
           oracleTimeout: '3600', // 1 hr
           targetName: hre.ethers.utils.formatBytes32String('ETH'),
-          defaultThreshold: fp('0.02').add(CBETH_ORACLE_ERROR).toString(), // 4%
+          defaultThreshold: fp('0.02').add(CBETH_ORACLE_ERROR).toString(), // 3%
           delayUntilDefault: bn('86400').toString(), // 24h
         },
         fp('1e-4'), // revenueHiding = 0.01%