Stargate Asset Plugin

[akshatmittal]

No description provided.

[tbrent]

I still have more to go through, but up-front: did you consider inheriting the plugin from AppreciatingFiatCollateral? I think it would allow you to skip re-implementing tryPrice() and refresh(). I guess you know no revenue hiding is required, so this way is a gas-saver? Still, I think I'd make the other tradeoff. Maybe there's something I'm not considering though...interested if you had more thoughts.

Similarly, what about inheriting from RewardableERC4626Vault for the wrapper? It might not be a good fit, but wanted to check.

[akshatmittal]

@tbrent Yeah I did consider the AppreciatingFiatCollateral route, but didn't do it because it didn't require revenue hiding and I intended to keep as much of the original submitted plugin as I can.

[pmckelvy1]

+1 for using RewardableERC4626Vault or RewardableERC20Wrapper, it looks like one of those should work (probably 4626