Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C4 39 use comet decimals instead of wrapper decimals. #889

Merged
merged 4 commits into from
Aug 22, 2023
Merged

C4 39 use comet decimals instead of wrapper decimals. #889

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8ab8143
use comet decimals instead of wrapper decimals.
pmckelvy1 Aug 10, 2023
ff85cc3
fix linting.
pmckelvy1 Aug 10, 2023
8ddeef2
cache comet decimals.
pmckelvy1 Aug 21, 2023
ff132ca
fix linting.
pmckelvy1 Aug 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion contracts/plugins/assets/compoundv3/CTokenV3Collateral.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,8 @@ contract CTokenV3Collateral is AppreciatingFiatCollateral {
}

function _underlyingRefPerTok() internal view virtual override returns (uint192) {
return shiftl_toFix(ICusdcV3Wrapper(address(erc20)).exchangeRate(), -int8(erc20Decimals));
return
shiftl_toFix(ICusdcV3Wrapper(address(erc20)).exchangeRate(), -int8(comet.decimals()));
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can cache as immutable var

}

/// Refresh exchange rates and update default status.
Expand Down
2 changes: 2 additions & 0 deletions contracts/plugins/assets/compoundv3/vendor/IComet.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,6 @@ interface IComet {

/// @dev uint104
function targetReserves() external view returns (uint256);

function decimals() external view returns (uint8);
}