RecollateralizationLib gas optimization #890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akshatmittal
approved these changes
Aug 11, 2023
|
changes look sound, but looks like dutch trade costs went up a little bit? |
nvm i understand now that those don't reference the correct starting gas |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Couple things happening in this PR
3.0.0-rc5actually wasRecollateralizationLibP1.solto reduce the need for a mulDiv for every single asset, on the range.bottom side.So the total diff shown in the PR is the result of (i) a large increase that was already present in
3.0.0-rc5and (ii) a moderate decrease that I applied by gas optimizing the range.bottom computation. Attaching a screenshot of just that decrease so it can be easily seen, but you could also go here