-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Process for veto analysis #20
base: master
Are you sure you want to change the base?
Conversation
…n' into lobis-prepare-for-multithreading
any GetInputEvent() const override { return fInputEvent; } | ||
any GetOutputEvent() const override { return fOutputEvent; } | ||
|
||
inline void SetGeant4Metadata(const TRestGeant4Metadata* metadata) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The process has access to TRestGeant4Metadata
through TRestRun
.
It is enough to do fGeant4Metada = GetMetadata<TRestGeant4Metadata>();
as it is done in other processes.
jgalan@sultan2:~/rest-framework/source/libraries/geant4$ grep -rnw . -e "GetMetadata"
./src/TRestGeant4NeutronTaggingProcess.cxx:145: fG4Metadata = GetMetadata<TRestGeant4Metadata>();
./src/TRestGeant4BlobAnalysisProcess.cxx:66: fG4Metadata = GetMetadata<TRestGeant4Metadata>();
./src/TRestGeant4AnalysisProcess.cxx:286: fG4Metadata = GetMetadata<TRestGeant4Metadata>();
./src/TRestGeant4VetoAnalysisProcess.cxx:123: fG4Metadata = GetMetadata<TRestGeant4Metadata>();
jgalan@sultan2:~/rest-framework/source/libraries/geant4$
Why do you want to set it externally?
For me the biggest problem of this PR is that it brings to I think we should find the time to meet (probably also with @juanangp) and think of an implementation that minimises the coding inside In my opinion, such minimisation of code inside Then, working out an upgrade of So, we just use |
Added
TRestGeant4ToDetectorSignalVetoProcess
for analysis of veto events and corresponding tests.