Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding LCG to thisREST.sh if LCG environment is identified #532

Merged
merged 17 commits into from
Jul 20, 2024
Merged

Conversation

jgalan
Copy link
Member

@jgalan jgalan commented Jul 13, 2024

jgalan Ok: 7 Powered by Pull Request Badge

The following PR adds some code inside thisREST.cmake to identify if we are using LCG environment. It will do so in case LCG_VERSION is found. And if it is found it will use the path defined by C_INCLUDE_PATH to load the environment inside thisREST.sh.

  • Some issues inside cmake_uninstall.cmake.in have also corrected.

@jgalan jgalan requested a review from LouisHelary July 13, 2024 18:53
Copy link

@LouisHelary LouisHelary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the comment I have left on the OS test, I would also try not to be too specific about the LCG release we currently use (that might change in the future). But otherwise the code looks good.

cmake/thisREST.cmake Outdated Show resolved Hide resolved
@jgalan
Copy link
Member Author

jgalan commented Jul 15, 2024

Besides the comment I have left on the OS test, I would also try not to be too specific about the LCG release we currently use (that might change in the future). But otherwise the code looks good.

The point here is to identify if the user has loaded LCG_104. I don't really know how to do this, perhaps there is a good way? I just check that the cmake command path is coming from /cvmfs/, lcg and x86_64-el9-gcc11. If we are able to identify which script was sourced in the environment, then probably we wold find a more generic and clean way to do this.

@jgalan jgalan requested a review from a team July 15, 2024 11:54
@jgalan jgalan marked this pull request as ready for review July 15, 2024 11:54
@jgalan jgalan requested a review from lobis as a code owner July 15, 2024 11:54
@jgalan
Copy link
Member Author

jgalan commented Jul 15, 2024

Apparently there is a LGC_VERSION defined as system variable:

[jgalan@naf-iaxo21 rest-framework]$ env | grep LCG_VERSION
LCG_VERSION=104

However, not sure about how to catch the architecture, perhaps just pick up the string from a random variable?

Just find LGC_104 and get the string between that and include?

C_INCLUDE_PATH=/cvmfs/sft.cern.ch/lcg/views/LCG_104/x86_64-el9-gcc11-opt/include

@jgalan jgalan requested a review from heucheld July 15, 2024 11:59
@LouisHelary
Copy link

jgalan Ok: 7 Powered by Pull Request Badge

The following PR adds some code inside thisREST.cmake to identify if we are using /cvmfs/sft.cern.ch/lcg/views/LCG_104/x86_64-el9-gcc11-opt/setup.sh. In case it is found, thisREST.sh will load first that script.

I have observed the following problem when using /cvmfs/.../lcg../ installation.
Screenshot 2024-07-13 at 20 50 11

I observe the same error, but only if I dont compile a release. If I use the script ./install_rest_release_LCG.sh v2.4.3 instead I can't reproduce the problem. Do you have older compilation logs available?

Install the project...
-- Install configuration: ""
CMake Warning at cmake_uninstall.cmake:2 (message):
Cannot find install manifest:
/tmp/cronjob-rest-release-v2.4.3/build/install_manifest.txt

-- Installing: /nfs/dust/iaxo/user/lhelary/LCG_rest/test/install/lib/libRestFramework.so

@jgalan jgalan changed the title Adding REST_LCG so that cvmfs/lcg will be loaded into thisREST.sh Adding LCG to thisREST.sh if LCG environment is identified Jul 16, 2024
@jgalan jgalan requested a review from nkx111 as a code owner July 16, 2024 19:37
@jgalan jgalan requested a review from LouisHelary July 17, 2024 06:39
@jgalan
Copy link
Member Author

jgalan commented Jul 18, 2024

Hi @lobis , there are issues with the certificate when downloading from sultan. Certificate validation may be set as a ROOT configuration parameter. Perhaps it can be changed in the docker image?

https://root-forum.cern.ch/t/error-in-davixopen-can-not-open-file-with-davix/19355

@lobis
Copy link
Member

lobis commented Jul 18, 2024

Hi @lobis , there are issues with the certificate when downloading from sultan. Certificate validation may be set as a ROOT configuration parameter. Perhaps it can be changed in the docker image?

https://root-forum.cern.ch/t/error-in-davixopen-can-not-open-file-with-davix/19355

I think this is just an issue with the web server, it shouldn't take long to fix (hopefully) on the server's end. We are aware of the issue.

@jgalan jgalan self-assigned this Jul 19, 2024
@jgalan
Copy link
Member Author

jgalan commented Jul 19, 2024

Great, then I think this PR is ready to be merged.

@jgalan jgalan merged commit a1cba19 into master Jul 20, 2024
64 checks passed
@jgalan jgalan deleted the jgalan_lcg branch July 20, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants