-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding LCG to thisREST.sh if LCG environment is identified #532
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides the comment I have left on the OS test, I would also try not to be too specific about the LCG release we currently use (that might change in the future). But otherwise the code looks good.
The point here is to identify if the user has loaded LCG_104. I don't really know how to do this, perhaps there is a good way? I just check that the |
Apparently there is a LGC_VERSION defined as system variable:
However, not sure about how to catch the architecture, perhaps just pick up the string from a random variable? Just find
|
for more information, see https://pre-commit.ci
Hi @lobis , there are issues with the certificate when downloading from sultan. Certificate validation may be set as a ROOT configuration parameter. Perhaps it can be changed in the docker image? https://root-forum.cern.ch/t/error-in-davixopen-can-not-open-file-with-davix/19355 |
I think this is just an issue with the web server, it shouldn't take long to fix (hopefully) on the server's end. We are aware of the issue. |
Great, then I think this PR is ready to be merged. |
The following PR adds some code inside
thisREST.cmake
to identify if we are using LCG environment. It will do so in caseLCG_VERSION
is found. And if it is found it will use the path defined byC_INCLUDE_PATH
to load the environment insidethisREST.sh
.cmake_uninstall.cmake.in
have also corrected.