From ac0c995b19ba98c8c8fd8a84c9c57ccf7c42db36 Mon Sep 17 00:00:00 2001 From: Igal Shilman Date: Fri, 4 Oct 2024 19:07:50 +0200 Subject: [PATCH] [e2e] Remove GHA workflow that creates e2e services docker (#24) * [e2e] Remove GHA workflow that creates e2e services docker * Fix pylint warnings --- .github/workflows/services.yaml | 53 -------------------------------- python/restate/context.py | 2 +- python/restate/handler.py | 2 ++ python/restate/object.py | 1 + python/restate/server_context.py | 1 + python/restate/service.py | 2 ++ python/restate/vm.py | 2 +- python/restate/workflow.py | 2 ++ 8 files changed, 10 insertions(+), 55 deletions(-) delete mode 100644 .github/workflows/services.yaml diff --git a/.github/workflows/services.yaml b/.github/workflows/services.yaml deleted file mode 100644 index 392c15f..0000000 --- a/.github/workflows/services.yaml +++ /dev/null @@ -1,53 +0,0 @@ -name: Build e2e test services docker image - -on: - push: - branches: [main] - tags: - - v** - -env: - REPOSITORY_OWNER: ${{ github.repository_owner }} - GHCR_REGISTRY: "ghcr.io" - GHCR_REGISTRY_USERNAME: ${{ github.actor }} - GHCR_REGISTRY_TOKEN: ${{ secrets.GITHUB_TOKEN }} - -jobs: - build-node-services-docker-image: - runs-on: ubuntu-latest - steps: - - name: Checkout repository - uses: actions/checkout@v4 - - - name: Set up QEMU dependency - uses: docker/setup-qemu-action@v2 - - - name: Set up Docker Buildx - uses: docker/setup-buildx-action@v2 - - - name: Log into GitHub container registry - uses: docker/login-action@v2 - with: - registry: ${{ env.GHCR_REGISTRY }} - username: ${{ env.GHCR_REGISTRY_USERNAME }} - password: ${{ env.GHCR_REGISTRY_TOKEN }} - - - name: Extract metadata (tags, labels) - id: meta - uses: docker/metadata-action@v5 - with: - images: | - ghcr.io/restatedev/python-test-services - tags: | - type=ref,event=branch - type=semver,pattern={{version}} - type=semver,pattern={{major}}.{{minor} - - - name: Build docker image - uses: docker/build-push-action@v3 - with: - context: ./test-services/ - push: true - platforms: linux/arm64,linux/amd64 - tags: ${{ steps.meta.outputs.tags }} - labels: ${{ steps.meta.outputs.labels }} diff --git a/python/restate/context.py b/python/restate/context.py index 99277f8..c108995 100644 --- a/python/restate/context.py +++ b/python/restate/context.py @@ -8,7 +8,7 @@ # directory of this repository or package, or at # https://github.com/restatedev/sdk-typescript/blob/main/LICENSE # -# pylint: disable=R0913,C0301 +# pylint: disable=R0913,C0301,R0917 """ Restate Context """ diff --git a/python/restate/handler.py b/python/restate/handler.py index 2094f43..7012d35 100644 --- a/python/restate/handler.py +++ b/python/restate/handler.py @@ -8,6 +8,8 @@ # directory of this repository or package, or at # https://github.com/restatedev/sdk-typescript/blob/main/LICENSE # + +# pylint: disable=R0917 """ This module contains the definition of the Handler class, which is used to define the handlers for the services. diff --git a/python/restate/object.py b/python/restate/object.py index 8befb25..ffd9b44 100644 --- a/python/restate/object.py +++ b/python/restate/object.py @@ -8,6 +8,7 @@ # directory of this repository or package, or at # https://github.com/restatedev/sdk-typescript/blob/main/LICENSE # +# pylint: disable=R0917 """ This module defines the Service class for representing a restate service. """ diff --git a/python/restate/server_context.py b/python/restate/server_context.py index c2b5dc0..02570a4 100644 --- a/python/restate/server_context.py +++ b/python/restate/server_context.py @@ -8,6 +8,7 @@ # directory of this repository or package, or at # https://github.com/restatedev/sdk-typescript/blob/main/LICENSE # +# pylint: disable=R0917 """This module contains the restate context implementation based on the server""" from datetime import timedelta diff --git a/python/restate/service.py b/python/restate/service.py index 93ff530..7cffb23 100644 --- a/python/restate/service.py +++ b/python/restate/service.py @@ -8,6 +8,8 @@ # directory of this repository or package, or at # https://github.com/restatedev/sdk-typescript/blob/main/LICENSE # + +# pylint: disable=R0917 """ This module defines the Service class for representing a restate service. """ diff --git a/python/restate/vm.py b/python/restate/vm.py index da35831..54b2551 100644 --- a/python/restate/vm.py +++ b/python/restate/vm.py @@ -11,7 +11,7 @@ """ wrap the restate._internal.PyVM class """ -# pylint: disable=E1101 +# pylint: disable=E1101,R0917 from dataclasses import dataclass import typing diff --git a/python/restate/workflow.py b/python/restate/workflow.py index 2614f8c..2e1f6b1 100644 --- a/python/restate/workflow.py +++ b/python/restate/workflow.py @@ -8,6 +8,8 @@ # directory of this repository or package, or at # https://github.com/restatedev/sdk-typescript/blob/main/LICENSE # + +# pylint: disable=R0917 """ This module defines the Service class for representing a restate service. """