Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for jsnext:main #820

Open
wants to merge 1 commit into
base: next
Choose a base branch
from

Conversation

simoncarpinter
Copy link

@simoncarpinter simoncarpinter commented Sep 13, 2016

  • fix typo (jsnext:main, not jsmain:next)
  • include src/ in distributed version so that jsnext:main references a real artifact

This change is Reviewable

* fix typo (`jsnext:main`, not `jsmain:next`)
* include `src/` in distributed version so that `jsnext:main` references a real artifact
@simoncarpinter
Copy link
Author

Actually, scratch this. jsnext:main expects to find code that has been transpiled except for its module syntax. Artifacts in src/ are not transpiled.

@deontologician
Copy link
Contributor

Hey, I think all we need to do is add an es6 output in compile.sh where we use the correct preset to transpile all but imports. Thanks for bringing this to our attention, I'll try getting it to work

@simoncarpinter
Copy link
Author

simoncarpinter commented Sep 13, 2016

Awesome :). For reference, I realised this was problematic somewhere around 11pm NZT last night and figured I'd close it until I could hack on it a little further -- I meant to come back around to it sometime in the next couple of days after digging into how your compiling/webpack setup works :). If you're looking into it now then that saves me some digging in unfamiliar territory (I'll admit that JS build tooling is one of my least favourite parts of the ecosystem).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants