Skip to content

This is a simple React Typescript app used for the code review portion of the test

Notifications You must be signed in to change notification settings

revenewco/frontend-code-review-test

Folders and files

NameName
Last commit message
Last commit date

Latest commit

 

History

4 Commits
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 

Repository files navigation

Frontend Code Review Exercise

Overview

This project contains a React application with a card payment form component that requires a code review. The main focus of this exercise is the CardPaymentForm.tsx file, which implements a form for collecting credit card information.

As a candidate, your task is to review the CardPaymentForm.tsx file and identify any issues, potential improvements, or best practices that should be applied. Consider aspects such as code quality, performance, security, accessibility, and user experience.

Project Structure

The main file for review is:

  • src/components/CardPaymentForm.tsx: This component implements a card payment form using React and Tailwind CSS.

Getting Started

To run this project locally, follow these steps:

  1. Clone the repository
  2. Install dependencies with npm install
  3. Start the development server with npm start

Available Scripts

In the project directory, you can run:

npm start

Runs the app in development mode and watches for CSS changes.

  • Opens http://localhost:3000 in the browser.
  • The page will reload if you make edits.
  • You will also see any lint errors in the console.

npm test

Launches the test runner in the interactive watch mode.

npm run build

Builds the app for production to the build folder.

  • It correctly bundles React in production mode and optimizes the build for the best performance.
  • The build is minified and the filenames include the hashes.

CSS Processing

This project uses Tailwind CSS. The CSS processing scripts are:

  • npm run start:css: Watches for changes in the input CSS file and recompiles Tailwind styles.
  • npm run build:css: Compiles Tailwind CSS for production.

Code Review Instructions

  1. Review the CardPaymentForm.tsx file thoroughly.
  2. Identify and document any issues you find, considering:
    • React best practices
    • TypeScript usage
    • Security concerns
    • Performance optimizations
    • Accessibility improvements
    • Code structure and organization
    • Error handling
    • User experience
  3. Suggest improvements or alternative implementations where appropriate.
  4. Consider how the component integrates with the rest of the application and if there are any architectural concerns.

Good luck with your review!

About

This is a simple React Typescript app used for the code review portion of the test

Resources

Stars

Watchers

Forks

Releases

No releases published

Packages

No packages published