From 4c2253a4373b61553fbabd2a95ac46f3834adc82 Mon Sep 17 00:00:00 2001 From: moznion Date: Wed, 21 Aug 2024 11:28:54 +0900 Subject: [PATCH] Put `${INPUT_RUBOCOP_FLAGS}` at the end of the other flags Since PR #103 introduced the default --fail-level flag, the severity level has become unchangeable due to this modification. Ideally, this flag (and others) should be overridable, but the RuboCop command prioritizes the flags that are specified last. This commit moves the user-specified flags to the end of the hard-coded flags, allowing them to be overridden. Signed-off-by: moznion --- script.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/script.sh b/script.sh index b34f6b6..9693ca0 100755 --- a/script.sh +++ b/script.sh @@ -123,10 +123,10 @@ fi echo '::group:: Running rubocop with reviewdog 🐶 ...' # shellcheck disable=SC2086 ${BUNDLE_EXEC}rubocop \ - ${INPUT_RUBOCOP_FLAGS} \ --require ${GITHUB_ACTION_PATH}/rdjson_formatter/rdjson_formatter.rb \ --format RdjsonFormatter \ --fail-level error \ + ${INPUT_RUBOCOP_FLAGS} \ "${CHANGED_FILES[@]}" \ | reviewdog -f=rdjson \ -name="${INPUT_TOOL_NAME}" \