Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action not raising non zero exit code on latest version #126

Open
cswilliams opened this issue Oct 3, 2024 · 0 comments
Open

Action not raising non zero exit code on latest version #126

cswilliams opened this issue Oct 3, 2024 · 0 comments

Comments

@cswilliams
Copy link

We noticed in the latest version with this configuration:

      - name: rubocop
        uses: reviewdog/action-rubocop@5e23bb67d79c93e5eb45bdae6d08b04052afec35 # v2.19.1
        with:
          rubocop_version: gemfile
          rubocop_extensions: rubocop-rails:gemfile rubocop-rspec:gemfile rubocop-rspec_rails:gemfile rubocop-performance:gemfile rubocop-capybara:gemfile rubocop-factory_bot:gemfile
          reporter: github-pr-check
          fail_on_error: true
          rubocop_flags: --config .rubocop.yml
          filter_mode: nofilter

that warnings are no longer causing the action to raise a non zero exit code. We also see this warning:

time=2024-10-03T20:49:01.820Z level=WARN msg="reviewdog: -fail-on-error is deprecated. Use -fail-level=any, or -fail-level=error for github-[pr-]check reporter instead. See also https://github.com/reviewdog/reviewdog/blob/master/CHANGELOG.md"

When we rolled back to v2.18.1 of the action, warnings are causing a non-zero exit code again.

I'm wondering if #124 needs to be merged in and then we need to set fail-level any to resolve this going forward?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant