Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update example to use Bundler #97

Merged
merged 1 commit into from
Feb 28, 2024
Merged

Update example to use Bundler #97

merged 1 commit into from
Feb 28, 2024

Conversation

javierjulio
Copy link
Contributor

@javierjulio javierjulio commented Feb 28, 2024

Since Rubocop has multiple gems, it's best to rely on Bundler to install them rather than not. Other popular gems like Rails use this Bundler feature to optimize their Rubocop workflows. This should be the preferred way to setup action-rubocop today to avoid issues like #92 and #83.

Closes #92

Since Rubocop has multiple gems, it's best to rely on Bundler to install them rather than not. Other popular gems like Rails use this same feature to optimize their rubocop workflows. https://github.com/rails/rails/blob/main/.github/workflows/rubocop.yml
@javierjulio javierjulio self-assigned this Feb 28, 2024
@javierjulio javierjulio merged commit 5340172 into master Feb 28, 2024
6 checks passed
@javierjulio javierjulio deleted the javierjulio-patch-1 branch February 28, 2024 17:18
@jakeonfire
Copy link

jakeonfire commented May 15, 2024

updated link to rails' (now-removed on main) rubocop gh action: https://github.com/rails/rails/blob/v7.0.8.1/.github/workflows/rubocop.yml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rubocop_extensions installation version from Gemfile does not work with wrong definition order of gems
2 participants