More, relatively easy TS conversion #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The only substantive changes are: - In `incentive-calculation.test.ts`, where the calls to `_.countBy` were missing an argument and thus not counting anything. - In `v0.test.js`, where `qs` is used to encode GET params, because it's much less picky about what types you give it. The only file left now is `src/routes/v0.js`, which won't be trivial, so I'm doing it separately.
oyamauchi
commented
Aug 2, 2023
| @@ -38,15 +42,15 @@ test('response is valid and correct', async t => { | |||
|
|
|||
| const calculatorResponse = JSON.parse(res.payload); | |||
|
|
|||
| const ajv = new Ajv({ | |||
| const ajv = new Ajv.default({ | |||
There was a problem hiding this comment.
This is a workaround for ajv-validator/ajv#2047 ; it's commented on in another test file.
RandomEtc
reviewed
Aug 2, 2023
| @@ -171,12 +179,18 @@ test('correctly evaluates scenerio "Married filing jointly w/ 2 kids and $250k H | |||
| t.equal(data.tax_credit_incentives.length, 10); | |||
|
|
|||
| // count the incentives by key used to de-dupe in UI: | |||
| const rebateCounts = _.countBy(i => i.item + i.item_type); | |||
RandomEtc
approved these changes
Aug 2, 2023
|
Verified very superficially that the test run appears to be running these tests. https://github.com/rewiringamerica/api.rewiringamerica.org/actions/runs/5744571228/job/15571117707?pr=104 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only substantive changes are:
In
incentive-calculation.test.ts, where the calls to_.countBywere missing an argument and thus not counting anything.
In
v0.test.js, whereqsis used to encode GET params, becauseit's much less picky about what types you give it.
The only file left now is
src/routes/v0.js, which won't be trivial,so I'm doing it separately.