Hoist the form header out of the form component #14
+117
−118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The header text isn't part of the calculator form, semantically. It will also need to be customizable for state-specific calcs. ## Test Plan Looks exactly the same as before in a browser. Cypress tests pass.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
RandomEtc
approved these changes
Aug 15, 2023
There was a problem hiding this comment.
Yep, makes a lot of sense!
This was a quick review with ignore whitespace.
Related, if you want to think about allowing callers to customize this header text, I made a ticket for that here - https://app.asana.com/0/1204738794846444/1205273704262120/f - I think web component "slots" do the trick, but I haven't thought hard about what that looks like in a stable/supported API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The header text isn't part of the calculator form, semantically. It
will also need to be customizable for state-specific calcs.
Test Plan
Looks exactly the same as before in a browser. Cypress tests pass.