Update item name feature to handle HEAR rebate projects #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
veekas
force-pushed
the
veekas-hear-item-names
branch
from
fbe2a0c
to
9343464
Compare
cjohnsbrown
reviewed
Sep 23, 2024
|
|
||
| test('HEAR rebates applicable to multiple appliances', () => { | ||
| expect( | ||
| itemName(['heat_pump_clothes_dryer', 'electric_stove'], msg, 'cooking'), |
There was a problem hiding this comment.
Should 'heat_pump_clothes_dryer' be included here?
cjohnsbrown
approved these changes
Sep 23, 2024
oyamauchi
approved these changes
Sep 23, 2024
There was a problem hiding this comment.
This is fine as-is, but I think introducing project into this logic allows for a more general solution:
- At the top of
itemName, compute the intersection of the Project's items and theitemsarray. - If the result is one item, use the existing single-item logic.
- If the result is multiple items (as it will be in all the preexisting cases), use the existing
multipleItemsName.
That would handle this HEAR case cleanly, as well as others I could imagine like a HEAR incentive that includes non-heat-pump dryers, heat pump dryers, and stoves. (Non-HP + HP dryer is already handled in the multi-item logic, so you'd get that for free without having to duplicate it in hearName, for example.)
Approving in case you want to just roll with this for expediency, but I think the above is where we should end up eventually.
|
Going to merge this to fix the outstanding problem with RI; we can follow up with my suggestion later. |
oyamauchi
added a commit
that referenced
this pull request
Sep 23, 2024
## Description This is what I was talking about in #187. It ended up being more involved than I thought, because Jest couldn't handle the JSX in the file `projects.tsx`. I tried other values of the `jsx` setting in tsconfig.json, but then Jest couldn't handle the magical `jsx:...` imports in projects.tsx (understandable; that's done using Parcel magic). So I factored out the icons from projects.tsx into a new file, and now the unit test works fine. ## Test Plan `yarn test`. The unit test is unmodified but still passes. Look at RI's HEAR incentive for stoves/dryers, and make sure it shows up and has the correct headline.
oyamauchi
added a commit
that referenced
this pull request
Sep 28, 2024
## Description This is what I was talking about in #187. It ended up being more involved than I thought, because Jest couldn't handle the JSX in the file `projects.tsx`. I tried other values of the `jsx` setting in tsconfig.json, but then Jest couldn't handle the magical `jsx:...` imports in projects.tsx (understandable; that's done using Parcel magic). So I factored out the icons from projects.tsx into a new file, and now the unit test works fine. ## Test Plan `yarn test`. The unit test is unmodified but still passes. Look at RI's HEAR incentive for stoves/dryers, and make sure it shows up and has the correct headline. Make sure the icons in the projects dropdown are correct. The one in the dropdown button should be purple, and in the menu should be grey-700 (i.e. almost black).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes an issue in which HEAR rebate cards weren't showing up when the technologies they applied to were considered to be in multiple project categories, i.e. Rhode Island's rebates being applicable to stoves and clothes dryers
Test Plan
Zip code: 02903; hhsize 1, income 30000