Refactor logic for HEAR multi-item incentive names #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Description This is what I was talking about in #187. It ended up being more involved than I thought, because Jest couldn't handle the JSX in the file `projects.tsx`. I tried other values of the `jsx` setting in tsconfig.json, but then Jest couldn't handle the magical `jsx:...` imports in projects.tsx (understandable; that's done using Parcel magic). So I factored out the icons from projects.tsx into a new file, and now the unit test works fine. ## Test Plan `yarn test`. The unit test is unmodified but still passes. Look at RI's HEAR incentive for stoves/dryers, and make sure it shows up and has the correct headline.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This Cypress failure is baffling -- it's an a11y check failure, claiming insufficient contrast on the text labels in some, but not all, of the project dropdown items (???) But it fails consistently, locally and on CI, so there must be something going on. |
veekas
approved these changes
Sep 26, 2024
Comment on lines
+198
to
+200
| const itemsToRender = incentiveItems.filter(item => | ||
| PROJECTS[project].items.includes(item), | ||
| ); |
There was a problem hiding this comment.
ah, yeah this makes more sense
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is what I was talking about in #187.
It ended up being more involved than I thought, because Jest couldn't
handle the JSX in the file
projects.tsx. I tried other values of thejsxsetting in tsconfig.json, but then Jest couldn't handle themagical
jsx:...imports in projects.tsx (understandable; that's doneusing Parcel magic).
So I factored out the icons from projects.tsx into a new file, and now
the unit test works fine.
Test Plan
yarn test. The unit test is unmodified but still passes.Look at RI's HEAR incentive for stoves/dryers, and make sure it shows
up and has the correct headline.
Make sure the icons in the projects dropdown are correct. The one in
the dropdown button should be purple, and in the menu should be
grey-700 (i.e. almost black).