Update consent language on the calculator #190
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
@bishiguro there's a translation process listed in CONTRIBUTING.md. Did you follow that?
There was a problem hiding this comment.
We've generally been OK with machine translation, but done our best to get a fluent Spanish speaker to look at it before merging. Failing that, someone like me who doesn't really "know" Spanish but has some basic knowledge of its grammar?
For canned language like this, I've gotten good use out of linguee.es, which matches up different-language versions of the same text on public websites. This way we can at least see if our phrasing is in wide use.
src/state-calculator-form.tsx
Outdated
| 'Get updates on incentives, rebates, and more from Rewiring America.', | ||
| )}{' '} | ||
| {msg('View our')}{' '} | ||
| {msg('By sharing your email, you agree to our')}{' '} |
There was a problem hiding this comment.
This one should have a description to tell translators what word is going to be next:
msg('By sharing your email, you agree to our', { desc: 'will be followed by "terms", as in terms of service' })
src/state-calculator-form.tsx
Outdated
| target="_blank" | ||
| > | ||
| {msg('terms')} | ||
| </a>{' '} | ||
| {msg('and to receive updates from Rewiring America.')}{' '} | ||
| {msg('We’ll store and protect your data in accordance with our')}{' '} |
There was a problem hiding this comment.
Same, add string description here
translations/es.xlf
Outdated
| @@ -781,6 +768,22 @@ | |||
| <trans-unit id="s4cc06ab146dba194"> | |||
| <source>Electric transportation</source> | |||
| <target>Transporte eléctrico</target></trans-unit> | |||
| <trans-unit id="sbb254e3763405cb1"> | |||
| <source>By sharing your email, you agree to our</source> | |||
| <target>Al compartir tu correo electrónico, aceptas nuestros</target> | |||
There was a problem hiding this comment.
This is one risk of machine translation: we've decided in this UI to use the Spanish formal "you", but this is using the informal "you" --- "tu" should be "su", and possibly "aceptas" needs to be conjugated differently?
(I don't actually know enough Spanish to do the translations from scratch myself, but I can recognize issues like this)
There was a problem hiding this comment.
Oof thank you for catching this.
|
I updated the screenshot in the PR description for the Spanish translated page. |
Description
We are updating our consent language on the calculator to ensure users know how we handle their data. This is needed ahead of storing calculator submission data in the PEP database.
Translation questions:
Changes
Test Plan
this.langin state-calculator.tsx to 'es' to verify that the Spanish translation renders (Is there a better way to test this locally?)Current state
New state (English)
New state (Spanish)