Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update consent language on the calculator #190

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Update consent language on the calculator #190

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ebaa425
update consent language on the calculator with es translation
bishiguro Oct 3, 2024
ea6bdea
add descriptions and switch to formal you
bishiguro Oct 4, 2024
18d278b
rebuild strings
bishiguro Oct 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/i18n/strings/es.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ export const templates = {
s025c15001425a689: `reemplazo de ventanas`,
s04009ba1826b5fca: `Idaho`,
s04c4b18eb3941d37: `California`,
s0571211bbc7d4cce: `Almacenaremos y protegeremos sus datos de acuerdo con nuestra`,
s07607bad0f288304: `reemplazo de puertas y ventanas`,
s07ecbff17886eb50: `un vehículo eléctrico usado`,
s084d252e989bd0d1: `¡Pronto dispondremos de más dinero!`,
Expand Down Expand Up @@ -63,7 +64,6 @@ export const templates = {
s4371bac1b748cdc4: `kilovatio`,
s4455d8f660ceaa3b: `10,000 Btuh`,
s459781c939bc83e5: `Ingresos del hogar`,
s45d344440b59c309: `Manténgase al día sobre incentivos, reembolsos, y más de Rewiring America.`,
s48ad5711856cfb44: `un vehículo híbrido enchufable nuevo`,
s48b23a6c3431c19e: `una secadora con bomba de calor`,
s4b0d7bd386d61b46: `Colorado`,
Expand All @@ -75,6 +75,7 @@ export const templates = {
s50994ba3f0a45429: `Presentado en colaboración con`,
s50c22fc6197c004a: `un vehículo nuevo`,
s50e95c2064db3522: `Calculadora por`,
s52ca6c8b262e0183: `y recibir actualizaciones de Rewiring America.`,
s56f9b2194465973e: `tonelada`,
s57355ce02837df3c: `Illinois`,
s579f082fddf5ad2d: `una bicicleta eléctrica`,
Expand All @@ -86,7 +87,6 @@ export const templates = {
s60361aefb7d94a79: `Ahora puede aprovechar los incentivos federales, pero es posible que su estado, ciudad y compañía de suministro de luz también ofrezcan incentivos para este proyecto. ¡Estamos trabajando duro para identificar cada uno de ellos!`,
s60d7e5b7ccbd7162: `Reembolso`,
s635e3d7c474426ce: `Descuento en una secadora con bomba de calor`,
s64fbe9b97e397b12: `Estamos dedicados a proteger su privacidad.`,
s675cdfc08b387d5a: `Ohio`,
s67d20e39f7ca49f9: `aislamiento del piso`,
s682a379fdd67cad0: `Alabama`,
Expand Down Expand Up @@ -149,7 +149,6 @@ export const templates = {
sb04b1070af7f7b76: `Washington, DC`,
sb1b20a59970ba607: `Incluye a cualquier persona con la que viva y que reclame como dependiente en sus impuestos, y a su cónyuge o pareja si presenta impuestos conjuntos.`,
sb1ef6ac20f1ddfff: `Descuento en un tablero eléctrico`,
sb21ad862204e6186: `Ver nuestros`,
sb3615709fedc9d4d: `Reembolsos para la Electrificación del Hogar y Electrodomésticos (HEAR)`,
sb5b955a693af9c2e: `Virginia`,
sb661e8297dd681e2: `Incentivo`,
Expand All @@ -159,7 +158,9 @@ export const templates = {
sb9e8a9bfc8bcf398: `Rhode Island`,
sba0e115b257c6647: `una bomba de calor de fuente de aire`,
sbafed52303428041: `https://homes.rewiringamerica.org/es/federal-incentives/home-efficiency-rebates`,
sbb254e3763405cb1: `Al compartir tu correo electrónico, aceptas nuestros`,
sbc39e1d2cd027ca9: `una bomba de calor con ductos`,
sbc6953a36ced943f: `política de privacidad`,
sbc6f031a2851e3fd: str`\$${0}/${1} de descuento en ${2}, hasta \$${3}`,
sbd6f35e4bb46fc68: `una estufa eléctrica/inducción`,
sbd73a9b9860a2ae3: `Massachusetts`,
Expand Down
16 changes: 11 additions & 5 deletions src/state-calculator-form.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,16 +110,22 @@ const renderEmailField = (
/>
<div className="mt-1 mx-3 text-color-text-secondary text-xsm leading-normal">
<slot name="email-helper">
{msg(
'Get updates on incentives, rebates, and more from Rewiring America.',
)}{' '}
{msg('View our')}{' '}
{msg('By sharing your email, you agree to our')}{' '}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one should have a description to tell translators what word is going to be next:

msg('By sharing your email, you agree to our', { desc: 'will be followed by "terms", as in terms of service' })

<a
className="text-color-action-primary font-medium"
href="https://rewiringamerica.org/terms-of-use"
href="https://www.rewiringamerica.org/terms"
target="_blank"
>
{msg('terms')}
</a>{' '}
{msg('and to receive updates from Rewiring America.')}{' '}
{msg('We’ll store and protect your data in accordance with our')}{' '}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same, add string description here

<a
className="text-color-action-primary font-medium"
href="https://content.rewiringamerica.org/view/privacy-policy.pdf"
target="_blank"
>
{msg('privacy policy')}
</a>
.
</slot>
Expand Down
11 changes: 0 additions & 11 deletions src/state-calculator.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,17 +232,6 @@ const StateCalculator: FC<{
<TextButton onClick={resetFormValues}>{msg('Reset')}</TextButton>
</div>
</div>
<div className="text-color-text-secondary text-[0.75rem] leading-tight pb-[0.1875rem]">
{msg('We’re dedicated to safeguarding your privacy.')}{' '}
<a
className="text-ra-color-text-link font-medium hover:underline"
target="_blank"
href="https://content.rewiringamerica.org/view/privacy-policy.pdf"
>
{msg('Learn more')}
</a>
.
</div>
<CalculatorForm
key={formKey}
stateId={stateId}
Expand Down
29 changes: 16 additions & 13 deletions translations/es.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,10 +255,6 @@
<source>Reset</source>
<target>Reiniciar</target>
</trans-unit>
<trans-unit id="s45d344440b59c309">
<source>Get updates on incentives, rebates, and more from Rewiring America.</source>
<target>Manténgase al día sobre incentivos, reembolsos, y más de Rewiring America.</target>
</trans-unit>
<trans-unit id="s8fd029fdcc452602">
<source>Enter your ZIP code to select a utility.</source>
<target>Ingrese su código postal para seleccionar una empresa de servicios eléctricos.</target>
Expand All @@ -275,20 +271,11 @@
<source>Email address</source>
<target>Dirección de correo electrónico</target>
</trans-unit>
<trans-unit id="sb21ad862204e6186">
<source>View our</source>
<note from="lit-localize">as in view our terms</note>
<target>Ver nuestros</target>
</trans-unit>
<trans-unit id="s180a95484a16608c">
<source>terms</source>
<note from="lit-localize">as in terms of service</note>
<target>términos</target>
</trans-unit>
<trans-unit id="s64fbe9b97e397b12">
<source>We’re dedicated to safeguarding your privacy.</source>
<target>Estamos dedicados a proteger su privacidad.</target>
</trans-unit>
<trans-unit id="s4455d8f660ceaa3b">
<source>10,000 Btuh</source>
<target>10,000 Btuh</target>
Expand Down Expand Up @@ -781,6 +768,22 @@
<trans-unit id="s4cc06ab146dba194">
<source>Electric transportation</source>
<target>Transporte eléctrico</target></trans-unit>
<trans-unit id="sbb254e3763405cb1">
<source>By sharing your email, you agree to our</source>
<target>Al compartir tu correo electrónico, aceptas nuestros</target>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is one risk of machine translation: we've decided in this UI to use the Spanish formal "you", but this is using the informal "you" --- "tu" should be "su", and possibly "aceptas" needs to be conjugated differently?

(I don't actually know enough Spanish to do the translations from scratch myself, but I can recognize issues like this)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oof thank you for catching this.

</trans-unit>
<trans-unit id="s52ca6c8b262e0183">
<source>and to receive updates from Rewiring America.</source>
<target>y recibir actualizaciones de Rewiring America.</target>
</trans-unit>
<trans-unit id="s0571211bbc7d4cce">
<source>We’ll store and protect your data in accordance with our</source>
<target>Almacenaremos y protegeremos sus datos de acuerdo con nuestra</target>
</trans-unit>
<trans-unit id="sbc6953a36ced943f">
<source>privacy policy</source>
<target>política de privacidad</target>
</trans-unit>
</body>
</file>
</xliff>
Loading