#623 add unique constraint to detection_reviews table

rfcx · Jun 5, 2024 · 5fa7c06 · 5fa7c06
1 parent 11726af
commit 5fa7c06
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 5 deletions.
diff --git a/core/_cli/migrations/20240604172307-add-unique-constraint-to-detection-reviews.js b/core/_cli/migrations/20240604172307-add-unique-constraint-to-detection-reviews.js
@@ -0,0 +1,18 @@
+'use strict'
+
+module.exports = {
+  up: async (queryInterface) => {
+    await queryInterface.sequelize.query(`
+      ALTER TABLE
+        "public"."detection_reviews"
+      ADD CONSTRAINT detection_reviews_unique_detection_id_user_id_constraint UNIQUE (detection_id, user_id)
+    `)
+  },
+  down: async (queryInterface) => {
+    await queryInterface.sequelize.query(`
+      ALTER TABLE
+        "public"."detection_reviews"
+      DROP CONSTRAINT detection_reviews_unique_detection_id_user_id_constraint IF EXISTS
+    `)
+  }
+}
diff --git a/core/detections/review.int.test.js b/core/detections/review.int.test.js
@@ -2844,12 +2844,12 @@ describe('POST /:streamId/detections/:start/review', () => {
         })
         await DetectionReview.create({
           detectionId: detection.toJSON().id,
-          userId: seedValues.otherUserId,
+          userId: seedValues.anotherUserId,
           status: -1
         })
         await DetectionReview.create({
           detectionId: detection.toJSON().id,
-          userId: seedValues.otherUserId,
+          userId: seedValues.differentUserId,
           status: -1
         })
 
@@ -2885,17 +2885,17 @@ describe('POST /:streamId/detections/:start/review', () => {
         })
         await DetectionReview.create({
           detectionId: detection.toJSON().id,
-          userId: seedValues.otherUserId,
+          userId: seedValues.anotherUserId,
           status: 1
         })
         await DetectionReview.create({
           detectionId: detection.toJSON().id,
-          userId: seedValues.primaryUserId,
+          userId: seedValues.differentUserId,
           status: -1
         })
         await DetectionReview.create({
           detectionId: detection.toJSON().id,
-          userId: seedValues.otherUserId,
+          userId: seedValues.primaryUserId,
           status: -1
         })