Add escape char to _ to avoid sql pattern matching #556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rassokhin-s
reviewed
Mar 5, 2024
core/streams/dao/index.js
Outdated
| @@ -116,7 +116,7 @@ async function query (filters, options = {}) { | |||
| if (filters.names) { | |||
| where.name = { | |||
| [Sequelize.Op.iLike]: { | |||
| [Sequelize.Op.any]: filters.names.map(n => `${n.replace(/^\*/, '%').replace(/\*$/, '%')}`) | |||
| [Sequelize.Op.any]: filters.names.map(n => `${n.replace(/^\*/, '%').replace(/\*$/, '%').replaceAll('_', '\\_')}`) | |||
There was a problem hiding this comment.
Did you check if sequelize has some built-in escape functions? I guess _ may be not the only character we may want to escape
There was a problem hiding this comment.
@rassokhin-s yes from this https://www.postgresql.org/docs/16/functions-matching.html#FUNCTIONS-LIKE
it has only _ and % for wildcard
rassokhin-s
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ DoD
(use na when API docs (Release notes, etc) do not need to be updated)
📝 Summary