Send timezone country code on create site #591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veckatimest
reviewed
Apr 17, 2024
core/streams/bl/index.js
Outdated
| } | ||
| // Get timezone and countryCode for Arbimon | ||
| const fullStream = { ...stream, ...(await dao.computedAdditions(stream)) } | ||
| return sequelize.transaction(async (transaction) => { |
There was a problem hiding this comment.
Why do we need transaction here? We only make one action to the database.
If creating on arbimon is failed, you will throw error anyway
There was a problem hiding this comment.
you're right. I added it when there were 2 actions there.
veckatimest
reviewed
Apr 17, 2024
core/streams/bl/index.js
Outdated
| const externalSite = await arbimonService.createSite(arbimonSite, options.idToken) | ||
| fullStream.externalId = externalSite.site_id | ||
| } catch (error) { | ||
| console.error(`Error creating site in Arbimon (stream: ${fullStream.id})`) |
There was a problem hiding this comment.
should we rollback arbimonService.createSite if we have failed inserting row to the database?
There was a problem hiding this comment.
If I remember correctly. we all agree to make it like this and won't rollback the arbimon side even it is failing on Core.
veckatimest
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ DoD
(use na when API docs (Release notes, etc) do not need to be updated)
📝 Summary
timezoneandcountry_codeon create Arbimon site