feat: find best_detections for classifications (#631) #632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tooseriuz
reviewed
Jun 18, 2024
core/_cli/migrations/20240404131807-create-best-detections.ts.js
Outdated
Show resolved
Hide resolved
Tooseriuz
reviewed
Jun 18, 2024
Tooseriuz
reviewed
Jun 18, 2024
core/detections/best-detections.js
Outdated
| @@ -22,6 +22,15 @@ const Converter = require('../../common/converter') | |||
| * description: List of stream ids to limit results | |||
| * in: query | |||
| * type: array|string | |||
| * - name: classifications | |||
There was a problem hiding this comment.
Suggested change
| * - name: classifications | |
| * - name: classification_ids |
some other places, we use classifications for classification name not ids. so better make it consistent
Tooseriuz
reviewed
Jun 18, 2024
core/detections/best-detections.js
Outdated
| @@ -83,18 +92,20 @@ router.get('/:jobId/best-detections', (req, res) => { | |||
| const { jobId } = req.params | |||
| const converter = new Converter(req.query, {}, true) | |||
| converter.convert('streams').optional().toArray() | |||
| converter.convert('classifications').optional().toArray() | |||
There was a problem hiding this comment.
Suggested change
| converter.convert('classifications').optional().toArray() | |
| converter.convert('classification_ids').optional().toArray() |
Tooseriuz
reviewed
Jun 18, 2024
core/detections/dao/index.js
Outdated
| @@ -90,7 +90,7 @@ async function defaultQueryOptions (filters = {}, options = {}) { | |||
|
|
|||
| async function defaultBestDetectionsQueryOptions (filters, opts) { | |||
| const { user, limit, offset, fields } = opts | |||
| const { streams, reviewStatuses } = filters | |||
| const { streams, classifications, reviewStatuses } = filters | |||
There was a problem hiding this comment.
Suggested change
| const { streams, classifications, reviewStatuses } = filters | |
| const { streams, classificationIds, reviewStatuses } = filters |
Tooseriuz
reviewed
Jun 18, 2024
core/detections/dao/index.js
Outdated
Comment on lines
124
to
127
| if (classifications) { | ||
| byClassicication = true | ||
|
|
||
| bestDetectionsWhere.classificationId = classifications |
There was a problem hiding this comment.
Suggested change
| if (classifications) { | |
| byClassicication = true | |
| bestDetectionsWhere.classificationId = classifications | |
| if (classificationIds) { | |
| byClassicication = true | |
| bestDetectionsWhere.classificationId = classificationIds |
grindarius
reviewed
Jun 18, 2024
There was a problem hiding this comment.
Would this migration gets run again?
There was a problem hiding this comment.
only somewhere where we did not have it yet (probably not)
Tooseriuz
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ DoD
(use na when API docs (Release notes, etc) do not need to be updated)
📝 Summary
Now when "classifications" query parameter is passed to
GET /classifier-jobs/{jobId}/best-detections
or
GET /classifier-jobs/{jobId}/best-detections/summary
The returned detections will be related to specific classification_id
🛑 Problems
💡 More ideas
Write any more ideas you have