fix: time gap to stop server on SIGTERM #633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ DoD
(use na when API docs (Release notes, etc) do not need to be updated)
📝 Summary
In the logs there are requests that got ECONNRESET in the moment there API gets SIGTERM signal. And we know that after that there are successful finished requests. So probably requests are reset because they were dialed during the sigterm (their request time is always arount 1-2ms)
So we should allow requests to finish dialling.
And at the same time the pod is excluded from the kubernetes service, so no new requests will come.
📸 Examples
Put screenshots or response/request examples here!
🛑 Problems
💡 More ideas
Write any more ideas you have