Update battle messages to Gen 5+ standards #3240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Before you continue modifying this, please fix failing test messages. |
MandL27
reviewed
Aug 19, 2023
src/battle_message.c
Outdated
| static const u8 sText_PkmnBlewAwaySpikes[] = _("{B_ATK_NAME_WITH_PREFIX} blew away\nspikes!"); | ||
| static const u8 sText_PkmnGotFree[] = _("{B_ATK_NAME_WITH_PREFIX} got free of\n{B_DEF_NAME_WITH_PREFIX}'s {B_BUFF1}!"); //not in gen 5+, generic rapid spin? | ||
| static const u8 sText_PkmnShedLeechSeed[] = _("{B_ATK_NAME_WITH_PREFIX} shed\nLeech Seed!"); //not in gen 5+, generic rapid spin? | ||
| static const u8 sText_PkmnBlewAwaySpikes[] = _("{B_ATK_NAME_WITH_PREFIX} blew away\nspikes!"); //not in gen 5+, generic rapid spin? |
There was a problem hiding this comment.
Gens 5+ use generic entry hazard removal text for this; unsure on Leech Seed tho
MandL27
reviewed
Aug 19, 2023
|
Finally got all tests to pass. Should be reviewable now |
…s_dynamic Merge with upcoming + Dynamic text wrapping for battle strings
AsparagusEduardo
requested changes
Oct 21, 2024
AsparagusEduardo
approved these changes
Oct 21, 2024
AlexOn1ine
pushed a commit
that referenced
this pull request
Oct 23, 2024
kittenchilly
added a commit
to kittenchilly/pokeemerald-expansion
that referenced
this pull request
Oct 26, 2024
AsparagusEduardo
pushed a commit
that referenced
this pull request
Oct 26, 2024
This was referenced Oct 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates almost every vanilla battle message to be consistent with gen 5+ and a lot of the custom messages we add. This results in better grammar and decapitalization of terms in most cases.
Also changes a few scripts that pertain to battle messages, as well as adding new weather and terrain strings if caused due to an overworld condition.
Images
Discord contact info
kittenchilly