Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix givemon not giving Cherish Ball #5022

Merged
merged 1 commit into from
Jul 24, 2024
Merged

Fix givemon not giving Cherish Ball #5022

merged 1 commit into from
Jul 24, 2024

Conversation

Sneed69
Copy link

@Sneed69 Sneed69 commented Jul 22, 2024

Discord contact info

duke5614

@AlexOn1ine AlexOn1ine merged commit 298ee34 into rh-hideout:master Jul 24, 2024
1 check passed
@pkmnsnfrn
Copy link
Collaborator

I only have one brain cell - why does this fix the problem? POKEBALL_COUNT is after BALL_CHERISH.

@AlexOn1ine
Copy link
Collaborator

I only have one brain cell - why does this fix the problem? POKEBALL_COUNT is after BALL_CHERISH.

because it checked for equality. A cherish ball turned into a pokeball.

@pkmnsnfrn
Copy link
Collaborator

Oh, the problem is the equals

changing the constant wasn't required, just removing the equals was

but I understand now, nvm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexOn1ine AlexOn1ine AlexOn1ine approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Sneed69 @pkmnsnfrn @AlexOn1ine