Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Axe Kick animation #5039

Merged
merged 4 commits into from
Jul 28, 2024
Merged

Conversation

kittenchilly
Copy link

Description

Fairly simple Axe Kick animation, made by me

Images

axekick

Discord contact info

kittenchilly

@hedara90 hedara90 self-requested a review July 25, 2024 19:55
@hedara90
Copy link
Collaborator

The delay between squish and unsquish feels a bit long. Probably because what the animation is used for in other places needed it.
It can be shortened by making a new static const union AffineAnimCmd sSquishTargetAffineAnimCmds for this animation.

squishFast.mp4

Copy link
Collaborator

@hedara90 hedara90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hex to dec

data/battle_anim_scripts.s Show resolved Hide resolved
data/battle_anim_scripts.s Show resolved Hide resolved
data/battle_anim_scripts.s Show resolved Hide resolved
@hedara90 hedara90 added the category: move animation Pertains to move animations label Jul 25, 2024
@Bassoonian Bassoonian added the new-feature Adds a feature label Jul 27, 2024
@kittenchilly
Copy link
Author

Alright, reviews addressed and I shortened the squish animation

@hedara90 hedara90 merged commit b54226d into rh-hideout:master Jul 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: move animation Pertains to move animations new-feature Adds a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants