Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Move Category icons #5080

Merged
merged 9 commits into from
Sep 9, 2024
Merged

Conversation

kittenchilly
Copy link

@kittenchilly kittenchilly commented Aug 2, 2024

Description

Updates them to use modern palettes and a few other tweaks as well

Images

pokeemerald-0 pokeemerald-1 pokeemerald-2

Discord contact info

kittenchilly

@hedara90 hedara90 added the General Doesn't fit under other labels label Aug 6, 2024
@hedara90
Copy link
Collaborator

hedara90 commented Aug 6, 2024

I don't know if I agree that they DPPt ones look better. Personally I don't like the color contrast on Physical, and Special lost the "special color" in my eyes, and I don't like the that the top/bottom margins are different. I prefer the HGSS ones over DPPt.
But it's matter of taste. Would probably need more voices in any case.

@Pawkkie
Copy link
Collaborator

Pawkkie commented Aug 6, 2024

Would probably need more voices in any case.

I also prefer the HGSS icons, especially for the Special icon colour. I agree with hedara. I don't necessarily mean for this agreement to be definitive, but I am certainly willing to add an extra voice.

@kittenchilly
Copy link
Author

I don't know if I agree that they DPPt ones look better. Personally I don't like the color contrast on Physical, and Special lost the "special color" in my eyes, and I don't like the that the top/bottom margins are different. I prefer the HGSS ones over DPPt. But it's matter of taste. Would probably need more voices in any case.

Physical wasn't even HGSS, its basically the same as what I changed it to. I figured the special color would the most contentious but I can change that. The top/bottom margins being what they were are unlike every other sprite like it in the game, including the type icons and it made some parts of it invisible if they were displayed on a white or black background

@kittenchilly
Copy link
Author

Updated with color tweaks based more on gen 5

@pkmnsnfrn pkmnsnfrn marked this pull request as draft August 28, 2024 02:57
@hedara90 hedara90 self-assigned this Sep 2, 2024
Copy link
Collaborator

@hedara90 hedara90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a config to keep the old icons?
#if around which image gets included and regular if for the 129->128 change (if the 129 is required for old icons)

@kittenchilly
Copy link
Author

Could you add a config to keep the old icons? #if around which image gets included and regular if for the 129->128 change (if the 129 is required for old icons)

Well the icons are already custom in the first place, so I'm not sure if this would really make sense. Its like keeping every version of a ds-style pokemon's sprite

@hedara90 hedara90 dismissed their stale review September 4, 2024 19:37

My mistake

@hedara90
Copy link
Collaborator

hedara90 commented Sep 4, 2024

Well the icons are already custom in the first place, so I'm not sure if this would really make sense. Its like keeping every version of a ds-style pokemon's sprite

Oh, right, sorry. I keep forgetting that it wasn't a Gen 3 thing.
Then it's just the color of the top part of the status icon, I think It's a bit too red, but other thoughts are welcome.

@kittenchilly kittenchilly marked this pull request as ready for review September 8, 2024 21:01
@hedara90 hedara90 merged commit ab279d9 into rh-hideout:master Sep 9, 2024
1 check passed
PeDIRL pushed a commit to PeDIRL/pokeemerald-expansion that referenced this pull request Sep 10, 2024
Update Category Icons to be more accurate to Gen 5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
General Doesn't fit under other labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants