Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Destiny Bond and OHKO moves are blocked by Dynamax #5877

Closed
wants to merge 2 commits into from

Conversation

AlexOn1ine
Copy link
Collaborator

Source: Bulbapedia

@AlexOn1ine AlexOn1ine added category: battle-mechanic Pertains to battle mechanics bugfix Bugfixes labels Dec 25, 2024
@hedara90
Copy link
Collaborator

Partially fixes #5777

@hedara90
Copy link
Collaborator

Could you write tests for these cases?
(Or wait 2 days until I get back to my ssh keys)

@AlexOn1ine
Copy link
Collaborator Author

Could you write tests for these cases? (Or wait 2 days until I get back to my ssh keys)

sec

@AlexOn1ine
Copy link
Collaborator Author

Closing this because there is a weird bug. The engine does not recognize Destiny Bond as the current move so if you even hardcode the movecheck the test still does not pass

    if (gCurrentMove == MOVE_DESTINY_BOND)
    {
        BattleScriptPushCursor();
        gBattlescriptCurrInstr = BattleScript_MoveBlockedByDynamax;
        return;
    }

@AlexOn1ine AlexOn1ine closed this Dec 26, 2024
@Bassoonian
Copy link
Collaborator

What about the OHKO moves?

@AlexOn1ine
Copy link
Collaborator Author

What about the OHKO moves?

There is already a test for them and they fail accordingly

@AlexOn1ine
Copy link
Collaborator Author

Closing this because there is a weird bug. The engine does not recognize Destiny Bond as the current move so if you even hardcode the movecheck the test still does not pass

    if (gCurrentMove == MOVE_DESTINY_BOND)
    {
        BattleScriptPushCursor();
        gBattlescriptCurrInstr = BattleScript_MoveBlockedByDynamax;
        return;
    }

I might be wrong here but I still don't understand where the bug is coming from

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Bugfixes category: battle-mechanic Pertains to battle mechanics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants