Atk Canceller refactor / reorder / clean up #5885
Merged
+698
−646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ready for review |
AlexOn1ine
changed the title
Bassoonian
reviewed
Dec 27, 2024
| @@ -1431,6 +1431,7 @@ DOUBLE_BATTLE_TEST("(DYNAMAX) G-Max One Blow bypasses Max Guard for full damage" | |||
| } | |||
|
|
|||
| // Bug Testing | |||
| // This test will fail if it's the first test a thread runs | |||
There was a problem hiding this comment.
Nope. There are two other comments like that in this file
There was a problem hiding this comment.
Confirmed that it's a thing as of current master
Bassoonian
approved these changes
Dec 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes based loosely on smogons reserch
Accidentally fixes a Stance Change bug