Skip to content

Version 1.8.6
Compare
Choose a tag to compare
@AsparagusEduardo AsparagusEduardo released this 01 Aug 23:55
· 1416 commits to master since this release
expansion/1.8.6
483121d
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Learn about vigilant mode. 
## How to update
- If you haven't set up a remote, run the command `git remote add RHH https://github.com/rh-hideout/pokeemerald-expansion`.
- Once you have your remote set up, run the command `git pull RHH expansion/1.8.6`.

🌋 REFACTORS 🌋

🧬 General 🧬

Fixed

  • Fixed Battle Frontier ineligibility blocking the entire party if it encountered a disabled species by @Bassoonian in #4997
  • Fixed random IVs given when using givemon only giving values from 1-31 by @cawtds in #5021
  • Fixed givemon not giving Cherish Ball by @Sneed69 in #5022

🐉 Pokémon 🐉

Added

Changed

Fixed

⚔️ Battle General ⚔️

Fixed

  • Fixed Debug Menu not properly updating the corresponding flags + general cleanup by @kittenchilly in #4643
  • Fixed spread damage in double battles by @AlexOn1ine in #5064
    • In double battles when B_POSITION_OPPONENT_LEFT fainted from the first hit of a spread move, the second hit dealt 100% of damage to B_POSITION_OPPONENT_RIGHT.

  • Removed unused Battle Script labels by @Bassoonian in #4839

    • data/battle_scripts_1.s
      • BattleScript_OctolockTryLowerDef
      • BattleScript_OctolockTurnDmgPrintMsg
      • BattleScript_StuffCheeksEatBerry
      • BattleScript_StrengthSapTryHp and its contents.
      • BattleScript_PartingShotEnd and its contents.
      • BattleScript_RototillerAffected
      • BattleScript_AutotomizeDoAnim
      • BattleScript_TryTailwindAbilitiesLoop_Ret
      • BattleScript_HitFromAtkCanceler
      • BattleScript_EffectMultiHit
      • BattleScript_BattleScript_EffectParalyzeNoTypeCalc
      • BattleScript_EffectTeleportTryToRunAway
      • BattleScript_WindPowerActivates_Ret
      • BattleScript_CottonDownReturn
      • BattleScript_ActivateWeatherAbilities_Increment
      • BattleScript_IntimidateEnd
      • BattleScript_SupersweetSyrupEnd
      • BattleScript_ActivateTerrainEffects_Increment
      • BattleScript_GrassyTerrainHpChange
      • BattleScript_GrassyTerrainLoopEnd
      • BattleScript_AbilityNoSpecificStatLossPrint
      • BattleScript_ArenaNothingDecided
      • BattleScript_ExtremeEvoboostAtk
      • BattleScript_BerserkGeneRet_Anim
    • data/battle_scripts_2.s
      • BattleScript_PrintCaughtMonInfo

  • Opportunist/Mirror Herb Refactor by @AlexOn1ine in #4928

    • Multiple fixes:
      • Opportunist stacking multiple boosts in one turn from opposing mons.
      • Increasing the stat by the wrong amount when copying opposing boost (eg. +6 boosts).
      • Opportunist no longer has a message.
      • Opportunist only play animations once for every stat boost.
    • Changes:
      • switchInBattlerCounter replaces both switchInAbilitiesCounter and switchInItemsCounter.
      • Removed STRINGID_OPPORTUNISTCOPIED and sText_OpportunistCopied.
      • Altered TryDoEventsBeforeFirstTurn to use a state switch (gBattleStruct->eventsBeforeFirstTurnState)
        • FIRST_TURN_EVENTS_START.
        • FIRST_TURN_EVENTS_OVERWORLD_WEATHER.
        • FIRST_TURN_EVENTS_TERRAIN.
        • FIRST_TURN_EVENTS_STARTING_STATUS.
        • FIRST_TURN_EVENTS_TOTEM_BOOST.
        • FIRST_TURN_EVENTS_NEUTRALIZING_GAS.
        • FIRST_TURN_EVENTS_SWITCH_IN_ABILITIES.
        • FIRST_TURN_EVENTS_OPPORTUNIST_1.
        • FIRST_TURN_EVENTS_ITEM_EFFECTS.
        • FIRST_TURN_EVENTS_OPPORTUNIST_2.
        • FIRST_TURN_EVENTS_END.

🤹 Moves 🤹

Added

Fixed

  • Fixed Diamond Storm's Defense increase applying to the target instead of the user by @Bassoonian in #4947
  • Fixed Psycho Shift check for Frostbite using CanBeFrozen instead of CanGetFrostbite by @Bassoonian in #4995
  • Fixed Sleep Talk failing on repeated attempts by @PhallenTree in #5009
  • Fixed Fury Cutter considering Parental Bond's second hit for its damage multiplier by @PhallenTree in #5030
  • Fixed Hidden Power damage category when B_PHYSICAL_SPECIAL_SPLIT < GEN_4 by @hedara90 in #5053
  • Fixed MoveEffectRemoveStatus (Sparkling Aria, Wake-Up Slap, ...) that cure Freeze/Frostbite using the other status' battlescript. by @PhallenTree in #5061

🎭 Abilities 🎭

Fixed

  • Fixed Toxic Debris incorrect side check by @PhallenTree in #5009
  • Fixed Snow Warning's description not being updated based on B_SNOW_WARNING by @kittenchilly in #5018
  • Fixed Mold Breaker abilities not properly checking battler actions in double battles causing them to not work by @PhallenTree in #5030
  • Fixed cantBeSurpressed ability check for breakable abilities by @AlexOn1ine in #5043
  • Fixed Stalwart and Propeller Tail not ignoring redirection from Storm Drain/Lightning Rod + tests by @PhallenTree in #5061

  • Fixed Trace not respecting the speed order like other switch-in abilities by @AlexOn1ine in #4941

    • Changes:
      • Removed: ABILITYEFFECT_TRACE1, ABILITYEFFECT_TRACE2 and moved their handling to ABILITYEFFECT_ON_SWITCHIN.
      • Removed gSpecialStatuses's traced field.

🧶 Items 🧶

Fixed

  • Jaboca/Rowap Berry recording the wrong item effects by @PhallenTree in #5009
  • Fixed Life Orb damaging its holder if it hits itself in confusion. by @PhallenTree in #5061

🤖 Battle AI 🤖

Documentation

  • Added AI Flags documentation to directory for new documentation site by @anrichtait in #5057

Fixed

  • Fixed typo that caused AI to use Upper Hand when it shouldn't by @Pawkkie in #4973
  • Fixed AI using U-Turn when only the Ace Pokémon is left in the party (#4748) by @Pawkkie in #4972
  • Fixed AI not being aware during calculations by @AlexOn1ine in #4992
  • Fixed AI_SetMoveAccuracy getting the wrong battler's ability by @PhallenTree in #5030

🧹 Other Cleanup 🧹

Fixed

🧪 Test Runner 🧪

Added

Changed

  • Improved Test Runner Summary by @AsparagusEduardo in #4641
    • Totals are now separated from the erroring test list.
    • Assumption Fails and Passing KNOWN_FAILINGs now have their own lists.

Fixed

  • Fixed tests failing when B_USE_FROSTBITE is set to TRUE by @fakuzatsu in #4986
  • Fixed tests not compiling outside of CI after incoming pret merge by @Bassoonian in #4998
  • Fixed Covert Cloak tests being in item_effect folder instead of hold_effect folder by @AlexOn1ine in #5073

📦 Pret merges 📦

Full Changelog: expansion/1.8.5...expansion/1.8.6

Contributors

AsparagusEduardo, SBird1337, and 10 other contributors
Assets 2
Loading