Add CMake support for RHash #103

uilianries · 2019-12-19T17:28:24Z

Hi!

This PR brings two CMake files which can build the library and executable.

I see you are running semaphore to build this project, but I can't update it locally, so you can update your script with:

mkdir cmake && pushd cmake
cmake .. -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_PREFIX=../results
cmake --build . --target install
popd
/usr/bin/find results/ -exec ls -ld '{}' ';'

Regards!

Signed-off-by: Uilian Ries <uilianries@gmail.com>

wdlkmpx · 2023-06-14T00:28:53Z

I have issues cross compiling static stuff, this might help

This should be merged, if we believe in true justice ...

jschueller · 2023-08-30T14:10:09Z

CMakeLists.txt

+
+option(USE_GETTEXT "Enable gettext (localization) support")
+
+set(SOURCE_FILES    "${CMAKE_CURRENT_SOURCE_DIR}/calc_sums.c"


no need for CMAKE_CURRENT_SOURCE_DIR, files are always relative to the source dir

jschueller · 2023-08-30T14:10:24Z

librhash/CMakeLists.txt

+option(USE_OPENSSL "Enable OpenSSL (optimized hash functions) support")
+option(OPENSSL_RUNTIME "Load OpenSSL at runtime if present")
+
+set(SOURCE_FILES    "${CMAKE_CURRENT_SOURCE_DIR}/algorithms.c"


jschueller · 2023-08-30T14:11:02Z

librhash/CMakeLists.txt

+install(TARGETS ${PROJECT_NAME}
+       EXPORT ${CMAKE_PROJECT_NAME}Config
+       RUNTIME DESTINATION bin
+       LIBRARY DESTINATION lib


if you use gnuinstalldirs then you can use CMAKE_INSTALL_LIBDIR/BINDIR/INCLUDEDIR

jschueller · 2023-08-30T14:12:34Z

librhash/CMakeLists.txt

+
+include(GNUInstallDirs)
+
+if(MSVC OR MSVC90 OR MSVC10)


MSVC90/MSVC10 already imply MSVC

jschueller · 2023-08-30T14:12:43Z

librhash/CMakeLists.txt

+include(GNUInstallDirs)
+
+if(MSVC OR MSVC90 OR MSVC10)
+    set(MSVC ON)


Signed-off-by: Uilian Ries <uilianries@gmail.com>

The build scripts in the project are quite non-standard and not too portable. Based on rhash/RHash#103

* librhash: migrate to Conan v2 * librhash: use OpenSSL v1 * librhash: bump deps * librhash: fix installation * librhash: downgrade OpenSSL * librhash: switch to custom CMakeLists.txt The build scripts in the project are quite non-standard and not too portable. Based on rhash/RHash#103 * librhash: bump openssl * librhash: add v1.4.4 * librhash: fix the list of sources used in CMakeLists.txt * librhash: fix missing lib prefix for libs * librhash: don't use PROJECT_NAME

* upgrading to Conan 2 * clean yaml * removed from config.yml * Cleanup * use tool_requires * wip * (#24282) bump boost dependency * (#23502) (#23474) simdjson/3.9.1: remove unnecessary constraints * (#18680) kealib: migrate to Conan v2 * kealib: migrate to Conan v2 * kealib: transitive_libs=True * kealib: simplify patch * kealib: add v1.5.1 * kealib: bump hdf5 * kealib: add min cppstd check * kealib: require GCC 6+ * kealib: drop v1.4.13 * kealib: bump to 1.5.2 * kealib: bump to 1.4.15 * kealib: fix MSVC lib name * kealib: bump hdf5 * kealib: fix MSVC library names * kealib: set HDF5_THREADSAFE based on hdf5 option * kealib: restore GCC 5 support Co-authored-by: Uilian Ries <uilianries@gmail.com> * kealib: fix a recipe bug * kealib: add CMAKE_POLICY_DEFAULT_CMP0077 * kealib: use valid_min_cppstd() * kealib: add cxx_std_11 to test_package * Add missing system lib in windows * Improve invalid config message. --------- Co-authored-by: Uilian Ries <uilianries@gmail.com> Co-authored-by: Rubén Rincón Blanco <git@rinconblanco.es> * (#19228) msix: migrate to Conan v2 * msix: migrate to Conan v2 * msix: use OpenSSL v1 * msix: bump deps * msix: fix Clang build issue * msix: fix OpenSSL 3 support * msix: add missing system libs * msix: simplify xml_parser option * msix: Clang 12 is not supported * msix: yaml * msix: test_package cxx_std_14 * (#24296) cpp-httplib: add version 0.16.0 * (#24297) glaze: add version 2.8.1 * (#24106) arrow: fix target names * Use the same CMake target names as upstream * Bugfix * Bugfix * Remove redundant calls to set_property("cmake_target_name") * Revert "Remove redundant calls to set_property("cmake_target_name")" This reverts commit fc113f0. * Bugfix * Bugfix * (#24307) libftp: add version 0.5.1 * (#24298) [sentry-native] Add versions 0.7.5/0.7.6 and remove 0.7.1/0.7.2 * (#24309) glaze: add version 2.8.2 * Update PULL_REQUEST_TEMPLATE.md (#24311) Update PR template: - Mention list of PRs by recipe - Simplify wording around testing locally - request that PRs are motivated and detailed (what/why/how) * (#24308) octo-logger-cpp: fix checksum for 1.12.0 * (#22456) proposal: update dependencies * proposal: update dependencies * Update recipes/proposal/all/conanfile.py * Update recipes/proposal/all/conanfile.py * Update recipes/proposal/all/conanfile.py * proposal: build fewer versions --------- Co-authored-by: Luis Caro Campos <3535649+jcar87@users.noreply.github.com> * (#18949) userspace-rcu: migrate to Conan v2 * userspace-rcu: migrate to Conan v2 * userspace-rcu: add v0.14.0 * userspace-rcu: no need for a custom bootstrap script * userspace-rcu: fix test_v1_package * userspace-rcu: disable apple-clang for v0.11.4 * (#18986) librhash: migrate to Conan v2 * librhash: migrate to Conan v2 * librhash: use OpenSSL v1 * librhash: bump deps * librhash: fix installation * librhash: downgrade OpenSSL * librhash: switch to custom CMakeLists.txt The build scripts in the project are quite non-standard and not too portable. Based on rhash/RHash#103 * librhash: bump openssl * librhash: add v1.4.4 * librhash: fix the list of sources used in CMakeLists.txt * librhash: fix missing lib prefix for libs * librhash: don't use PROJECT_NAME * (#18950) pbc: migrate to Conan v2 * pbc: migrate to Conan v2 * pbc: bump gmp * pbc: use winflexbison on Windows * pbc: add transitive_headers=True to gmp * pbc: fix build * pbc: fix apple cross building bug * pbc: transitive_libs=True * pbc: bump deps * pbc: fix configure issue * pbc: fix to_apple_arch() * pbc: add MSVC support * pbc: add AutotoolsDeps workaround for MSVC * pbc: add MSVC ./configure workarounds * pbc: not compatible with MSVC due to use of GNU extensions * pbc: fix_apple_shared_install_name() * (#18948) hiredis/0.x.x: remove 0.x recipe * hiredis/0.x.x: migrate to Conan v2 * hiredis/0.x.x: fix_apple_shared_install_name(self) * Dropped support for very old 0.x.x versions --------- Co-authored-by: PerseoGI <perseog@jfrog.com> * (#23997) mini: add recipe * mini: add recipe * Update recipes/mini/all/test_package/test_package.cpp --------- Co-authored-by: Luis Caro Campos <3535649+jcar87@users.noreply.github.com> * (#24300) octo-logger-cpp: bumped fmt dependency * (#20586) pcre2: fix invalid pcre2-config output for static libs * pcre2: fix invalid pcre2-config output for static libs * pcre2: ignore noise from self.run() * pcre2: make pcre2-config test a bit more robust * pcre2: handle debug postfix correctly * pcre2: no need for win_bash = True * pcre2: drop self.tool_requires(self.tested_reference_str) * Update recipes/pcre2/all/test_package/conanfile.py * Update recipes/pcre2/all/test_package/conanfile.py * Update recipes/pcre2/all/test_package/conanfile.py * Update recipes/pcre2/all/test_package/conanfile.py * Update recipes/pcre2/all/test_package/conanfile.py * Update recipes/pcre2/all/test_package/conanfile.py * fix replace for 10.43 * fix fix replace --------- Co-authored-by: Daniel <danimanzaneque@gmail.com> * (#19239) pro-mdnsd: migrate to Conan v2 Co-authored-by: Carlos Zoido <mrgalleta@gmail.com> * (#24262) reflect-cpp: add option for using with msgpack * reflect-cpp: add option for using with msgpack * reflect-cpp: fix with_msgpack option --------- Co-authored-by: Luis Caro Campos <3535649+jcar87@users.noreply.github.com> * (#24011) arrow: add version 16.1.0 * arrow: add version 16.1.0 * Format build method --------- Co-authored-by: PerseoGI <perseog@jfrog.com> * (#24312) [bot] Update authorized users list (2024-06-13) Co-authored-by: conan-center-bot <luism+c3ibot@jfrog.com> * (#24273) [boost] Add -fcoroutines for GCC10 only * Add -fcoroutines for GCC10 only Signed-off-by: Uilian Ries <uilianries@gmail.com> * Use b2 ranged version Signed-off-by: Uilian Ries <uilianries@gmail.com> --------- Signed-off-by: Uilian Ries <uilianries@gmail.com> * (#24318) glaze: add version 2.8.4 * (#24316) jsoncons: add version 0.176.0 * (#24306) libmaxminddb: add version 1.10.0 * libmaxmind: add version 1.10.0 * add with_binaries option * Cleanups * append PATH on with_binaries=True --------- Co-authored-by: Rubén Rincón Blanco <git@rinconblanco.es> * (#24323) pcre2: add version 10.44 * test pr do not merge * Revert "test pr do not merge" This reverts commit f146b96. * (#24328) change gn validate to validate_build * package license * update to set_property for cmake_build_modules * add library type --------- Signed-off-by: Uilian Ries <uilianries@gmail.com> Co-authored-by: Rubén Rincón Blanco <git@rinconblanco.es> Co-authored-by: Jean-Marco Alameddine <jean-marco.alameddine@udo.edu> Co-authored-by: Jie Cheng <chengjiehust@gmail.com> Co-authored-by: Martin Valgur <martin.valgur@gmail.com> Co-authored-by: Uilian Ries <uilianries@gmail.com> Co-authored-by: toge <toge.mail@gmail.com> Co-authored-by: Roberto Rossini <71787608+robomics@users.noreply.github.com> Co-authored-by: Martin Delille <martin@delille.org> Co-authored-by: Luis Caro Campos <3535649+jcar87@users.noreply.github.com> Co-authored-by: PerseoGI <perseog@jfrog.com> Co-authored-by: Daniel <danimanzaneque@gmail.com> Co-authored-by: Carlos Zoido <mrgalleta@gmail.com> Co-authored-by: Beartama <8091245+uyha@users.noreply.github.com> Co-authored-by: Conan Center Index Bot <54393557+conan-center-bot@users.noreply.github.com> Co-authored-by: conan-center-bot <luism+c3ibot@jfrog.com>

uilianries added 2 commits December 19, 2019 14:19

Add basic CMake support

4a567e9

Signed-off-by: Uilian Ries <uilianries@gmail.com>

Update install description with CMake]

2dafe69

Signed-off-by: Uilian Ries <uilianries@gmail.com>

uilianries mentioned this pull request Dec 20, 2019

Add librhash/1.3.8 conan-io/conan-center-index#277

Merged

4 tasks

rhash force-pushed the master branch from 821b030 to 09187bb Compare March 21, 2021 21:37

jschueller reviewed Aug 30, 2023

View reviewed changes

librhash/CMakeLists.txt Outdated

include(GNUInstallDirs)

if(MSVC OR MSVC90 OR MSVC10)

Copy link

jschueller Aug 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MSVC90/MSVC10 already imply MSVC

jschueller reviewed Aug 30, 2023

View reviewed changes

librhash/CMakeLists.txt Outdated

include(GNUInstallDirs)

if(MSVC OR MSVC90 OR MSVC10)

set(MSVC ON)

Copy link

jschueller Aug 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uneeded

simplify cmake file

e601748

Signed-off-by: Uilian Ries <uilianries@gmail.com>

valgur added a commit to valgur/conan-center-index that referenced this pull request Nov 6, 2023

librhash: switch to custom CMakeLists.txt

a339bd9

The build scripts in the project are quite non-standard and not too portable. Based on rhash/RHash#103

valgur added a commit to valgur/conan-center-index that referenced this pull request Jan 19, 2024

librhash: switch to custom CMakeLists.txt

0b200ba

The build scripts in the project are quite non-standard and not too portable. Based on rhash/RHash#103

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add CMake support for RHash #103

Add CMake support for RHash #103

uilianries commented Dec 19, 2019 •

edited

Loading

wdlkmpx commented Jun 14, 2023

jschueller Aug 30, 2023

jschueller Aug 30, 2023

jschueller Aug 30, 2023 •

edited

Loading

jschueller Aug 30, 2023

jschueller Aug 30, 2023


		option(USE_GETTEXT "Enable gettext (localization) support")

		set(SOURCE_FILES "${CMAKE_CURRENT_SOURCE_DIR}/calc_sums.c"

Add CMake support for RHash #103

Are you sure you want to change the base?

Add CMake support for RHash #103

Conversation

uilianries commented Dec 19, 2019 • edited Loading

wdlkmpx commented Jun 14, 2023

jschueller Aug 30, 2023

Choose a reason for hiding this comment

jschueller Aug 30, 2023

Choose a reason for hiding this comment

jschueller Aug 30, 2023 • edited Loading

Choose a reason for hiding this comment

jschueller Aug 30, 2023

Choose a reason for hiding this comment

jschueller Aug 30, 2023

Choose a reason for hiding this comment

uilianries commented Dec 19, 2019 •

edited

Loading

jschueller Aug 30, 2023 •

edited

Loading