Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: test scripts and readme doc about uninstallation #330

Merged
merged 1 commit into from
Aug 21, 2023
Merged

fix: test scripts and readme doc about uninstallation #330

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,14 +36,17 @@ It is easier to use the web console to remove the installed operator.
Instructions below removes all traces of what was setup in the previous step
including removing the catalog.
```
kubectl delete -n operators csv \
oc delete -n operators csv \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a follow-up we could replace kubectl by oc across the whole OpenShift section.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

totally +1, it'll help being specific to openshift, although kubectl would work as well :D

-l operators.coreos.com/observability-operator.operators=

kubectl delete -n openshift-operators \
oc delete -n openshift-operators \
installplan,subscriptions \
-l operators.coreos.com/observability-operator.operators=

kubectl delete -f hack/olm
oc delete -f hack/olm

oc delete crds "$(oc api-resources --api-group=monitoring.rhobs -o name)"

```

### Kubernetes
Expand Down Expand Up @@ -76,6 +79,9 @@ kubectl delete -n operators \
-l operators.coreos.com/observability-operator.operators=

kubectl delete -f hack/olm/k8s

kubectl delete crds "$(kubectl api-resources --api-group=monitoring.rhobs -o name)"

```
## Development

Expand Down
1 change: 1 addition & 0 deletions test/run-e2e-ocp.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ delete_obo() {

oc delete -f hack/olm/subscription.yaml || true
oc delete -f hack/olm/catalog-src.yaml || true
oc delete crds "$(oc api-resources --api-group=monitoring.rhobs -o name)"
ok "uninstalled ObO"
}

Expand Down
Loading