fix: update github workflow to use node>=16 #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielmellado
force-pushed
the
change_gh_actions_node
branch
from
ba57d7b
to
33f0034
Compare
danielmellado
changed the title
|
maybe we can switch to https://github.com/helm/kind-action which seems to see more updates? |
|
Doing the same in prometheus-operator: prometheus-operator/prometheus-operator#5817 |
Yes, I also submitted a fix to engineerd/setup-kind (engineerd/setup-kind#247) but doesn't seem to have any traction. I'll modify and update this PR to the helm action, thanks! |
GitHub workflow is giving off a warning about the node version used for some of the actions (engineerd/setup-kind) being deprecated. This commit changes the plugin to helm/kind-action to avoid that. Signed-off-by: Daniel Mellado <dmellado@redhat.com>
danielmellado
force-pushed
the
change_gh_actions_node
branch
from
33f0034
to
32aa48b
Compare
simonpasquier
approved these changes
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub workflow is giving off a warning about the node version used for
some of the actions (engineerd/setup-kind) being deprecated. This commit
changes the plugin to helm/kind-action to avoid that.
Signed-off-by: Daniel Mellado dmellado@redhat.com