Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

COO-481: feat: require TLS client certificate for /metrics #611

Merged
merged 1 commit into from
Nov 5, 2024
Merged

COO-481: feat: require TLS client certificate for /metrics #611

merged 1 commit into from
Nov 5, 2024

Conversation

simonpasquier
Copy link
Contributor

No description provided.

@simonpasquier simonpasquier requested a review from a team as a code owner October 29, 2024 16:30
@simonpasquier simonpasquier requested review from slashpai and JoaoBraveCoding and removed request for a team October 29, 2024 16:31
@openshift-ci openshift-ci bot requested review from jan--f and rexagod October 29, 2024 16:31
@simonpasquier simonpasquier changed the title feat: require TLS client certificate for /metrics COO-481: feat: require TLS client certificate for /metrics Oct 29, 2024
@simonpasquier
Copy link
Contributor Author

/hold

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Oct 29, 2024 •
edited by openshift-ci bot
Loading

@simonpasquier: This pull request references COO-481 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.18.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Oct 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jan--f
Copy link
Collaborator

jan--f commented Nov 4, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 4, 2024
@simonpasquier
Copy link
Contributor Author

/test observability-operator-e2e

@openshift-ci openshift-ci bot removed the lgtm label Nov 4, 2024
@jan--f
Copy link
Collaborator

jan--f commented Nov 4, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 4, 2024
@simonpasquier
feat: require TLS client certificate for /metrics
df8eb04 
Signed-off-by: Simon Pasquier <spasquie@redhat.com>
@openshift-ci openshift-ci bot removed the lgtm label Nov 4, 2024
@simonpasquier
Copy link
Contributor Author

/retest-required

@jan--f
Copy link
Collaborator

jan--f commented Nov 4, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 4, 2024
@simonpasquier
Copy link
Contributor Author

/hold cancel

@jan--f
Copy link
Collaborator

jan--f commented Nov 5, 2024

/retest

@openshift-merge-bot openshift-merge-bot bot merged commit 8cb5a11 into rhobs:main Nov 5, 2024
11 checks passed
@simonpasquier simonpasquier deleted the COO-481 branch November 5, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slashpai slashpai Awaiting requested review from slashpai slashpai is a code owner automatically assigned from rhobs/observability-operator-maintainers

@JoaoBraveCoding JoaoBraveCoding Awaiting requested review from JoaoBraveCoding JoaoBraveCoding is a code owner automatically assigned from rhobs/observability-operator-maintainers

@jan--f jan--f Awaiting requested review from jan--f

@rexagod rexagod Awaiting requested review from rexagod

Assignees

@jan--f jan--f

Labels
approved jira/valid-reference lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@simonpasquier @openshift-ci-robot @jan--f