Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retryer.call should not catch Errors like OOME #67

Open
sslavic opened this issue Nov 15, 2016 · 0 comments
Open

Retryer.call should not catch Errors like OOME #67

sslavic opened this issue Nov 15, 2016 · 0 comments

Comments

@sslavic
Copy link

sslavic commented Nov 15, 2016

Please consider catching "Exception | RuntimeException e" instead of Throwable at https://github.com/rholder/guava-retrying/blob/master/src/main/java/com/github/rholder/retry/Retryer.java#L162 not to catch and wrap Error potentially thrown by the called Callable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sslavic