Skip to content

Commit

Permalink
Fix bug in APRS-IS server login.
Browse files Browse the repository at this point in the history
The `vers` field in the APRS-IS server login is optional, but if you
choose to use it (`aprs-weather-submit` does), then you need to send
the app name and version, separated by a space. I was using a slash.
My bad.  This commit fixes it.

That being said, I've never had a problem with this app before, so
I'm going to guess that this is a mostly cosmetic change.
  • Loading branch information
rhymeswithmogul committed Nov 4, 2024
1 parent a627077 commit cf70069
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

## Next version
- Fixed a bug where v1.8.1 would not handle timeouts correctly using the Win32 API. The changes are queued for the next version, though I've already included them in the released binaries.
- Fixed a bug in APRS server negotiation. The `vers` field expects the app name and version, separated by a space; however, I was separating it with a forward slash instead.

## Version 1.8.1
<time datetime="2024-11-03">November 3, 2024</time>
Expand Down
2 changes: 1 addition & 1 deletion src/aprs-is.c
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,7 @@ sendPacket (const char* const restrict server,
}

/* Authenticate */
sprintf(buffer, "user %s pass %s vers %s/%s\n",
sprintf(buffer, "user %s pass %s vers %s %s\n",
username, password, PACKAGE, VERSION);
#ifdef DEBUG
printf("> %s", buffer);
Expand Down

0 comments on commit cf70069

Please sign in to comment.