Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved library integration and extensibility #46

Merged
merged 7 commits into from
Oct 13, 2023
Merged

Improved library integration and extensibility #46

merged 7 commits into from
Oct 13, 2023

Conversation

sideprojectslab
Copy link
Contributor

made it easier to create a new vendor/user/project-specific platform without altering the bluepad32 library contents

Copy link
Owner

@ricardoquesada ricardoquesada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check the bulider which failed.

Please, also send the PR against develop and not main.
Ty!

@@ -89,5 +93,8 @@ if(DEFINED ENV{BLUEPAD32_ARDUINO})
# linker will always include them.
#
# (As they are C++ symbol, we need to add the C++ mangled names.)
target_link_libraries(${COMPONENT_LIB} INTERFACE "-u _Z6setupv -u _Z4loopv")
list(APPEND ext_symbols "-u _Z6setupv -u _Z4loopv")
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: indentation

@sideprojectslab sideprojectslab changed the base branch from main to develop October 13, 2023 04:23
@ricardoquesada ricardoquesada merged commit 7da703c into ricardoquesada:develop Oct 13, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants