Fixed auth to use AWS package and use all the newest packages #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
requirements.txt
Outdated
| attrs>=18.1.0,<19.0.0 | ||
| trans>=2.1.0,<3.0.0 | ||
| certifi>=2023.7.22 # not directly required, pinned by Snyk to avoid a vulnerability | ||
| requests |
There was a problem hiding this comment.
please put version ranges, otherwise things can randomly break
|
I added the version numbers (not ranges, since its very hard to go test other versions for each package). The latest works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Since it would not run on python 3.12, I updated mainly the auth.py to use the AWS official package for signing the url.
I also removed the limits on the various requirments. All tests pass with python 3.12.
I am not sure it will work on 2.7, i did not check, since I don't have it installed. I guess removing support for 2.7 is a good idea.
many thanks
Raz