Support infinite carousels #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…port infinite carousels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I finally came across a requirement for infinite carousels so I've made a minor tweak to react snap carousel to better support them.
The tweak isn't directly related to infinite carousels, but it helps with the implementation I'm using -- an example of which can be found in this PR.
Long story short, you can now add a data attribute
<li data-should-snap="true" />to an item and it will become a snap point -- that is to say it will be used as the first item of a new page of items.Why is it a DOM attribute and not a React prop?
Fundamentally React Snap Carousel computes "pages" based on the DOM layout which isn't modelled in React code, so it seems both appropriate and pragmatic to offer up a DOM-based API to tell React Snap Carousel where to start a page from -- it's conceptually the same as adding some CSS to an item, causing the page groupings to change.