Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix documentation #173

Merged
merged 9 commits into from
Oct 22, 2023
Merged

Fix documentation #173

merged 9 commits into from
Oct 22, 2023

Conversation

rikhuijzer
Copy link
Owner

@rikhuijzer rikhuijzer commented Oct 22, 2023 •
edited
Loading

Was introduced in #172. This PR re-enables Docs builds on PRs to avoid similar problems later.

@rikhuijzer rikhuijzer changed the title Fix documentation build Fix documentation Oct 22, 2023
@rikhuijzer
Copy link
Owner Author

rikhuijzer commented Oct 22, 2023 •
edited
Loading

Ah! It has to be a quote for eval of course and a string when passed into the the distributed runner.

julia> eval("x = 1")
"x = 1"

julia> x
ERROR: UndefVarError: `x` not defined

@rikhuijzer rikhuijzer enabled auto-merge (squash) October 22, 2023 18:15
@rikhuijzer rikhuijzer merged commit fd1f1c9 into main Oct 22, 2023
4 checks passed
@rikhuijzer rikhuijzer deleted the rh/fix-docs branch October 22, 2023 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rikhuijzer