Bugfix for workspace_custom_startup_expr check & updated compat #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for this nice PR
I was already wondering why I kept seeing that error. Thanks for figuring out the root cause (the bug was introduced in #171)! I'll merge this once the tests pass and I'll release a new version soon. I think Pluto is gonna do a new release soon (fonsp/Pluto.jl@cb21fa9), so I'll wait for that before tagging a new release here. |
Merged
|
No problem & sounds good, thank you! |
rikhuijzer
added a commit
that referenced
this pull request
Oct 22, 2023
Was introduced in #172. This PR re-enables Docs builds on PRs to avoid similar problems later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this bugfix, the "Expected the
workspace_custom_startup_exprsetting to not be set by someone else; overriding it." warning message always appeared when evaluating multiple Pluto notebooks due to a quote vs string inconsistency. Also updated compat & example.jl for the latest package releases.