Revert escaping dollar symbol #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
rikhuijzer
added a commit
that referenced
this pull request
Jun 12, 2024
Inline math via dollar symbols can conflict with using dollar symbols for representing dollars. Fixing this by escaping dollars is not an option since it is hard to run KaTeX and unescape dollars in Javascript (see also #193). So instead of fixing the dollars for representing currency, this patch fixes the dollar for representing inline math by converting the dollars to `\(` and `\)`. This is also how Franklin.jl handles it. In other words, Franklin.jl also converts dollar symbols for inline math to `\(` and `\)`. ## Tasks - [x] Add test to verify that Pluto.jl returns `<span class="tex">$x$</span>` for `$x$`. - [x] Verify that Documenter.jl also interprets `\(` and `\)` as inline math.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Franklin automatically converts
$x$to\(x\)and Pluto to<span>etc, so the best option is to avoid convert$x$via KaTeX in Javascript post processing. Then, dollars do not have to be escaped. This solves the problem where it is actually not so straightforward in Javascript to un-escape dollar symbols after running KaTeX.EDIT: Maybe better would be for PlutoStaticHTML.jl to not escape dollar symbols, but instead to convert inline math dollar symbols to
\(and\)like Franklin.jl does. Pluto.jl by defaults converts inline math such as$r$to(without newlines; these are added here for readability.)