Remove show

proto/gen/rill/runtime/v1/runtime.swagger.yaml

@@ -3896,9 +3896,6 @@ definitions:
           $ref: '#/definitions/v1ComponentVariable'
       output:
         $ref: '#/definitions/v1ComponentVariable'
-      show:
-        type: string
-        description: Templated string that should evaluate to a boolean.
       definedInCanvas:
         type: boolean
   v1ComponentState:

proto/rill/runtime/v1/resources.proto

@@ -679,7 +679,6 @@ message ComponentSpec {
   google.protobuf.Struct renderer_properties = 5;
   repeated ComponentVariable input = 8;
   ComponentVariable output = 9;
-  string show = 10; // Templated string that should evaluate to a boolean.
   bool defined_in_canvas = 6;
 }
 

runtime/compilers/rillv1/parse_component.go

@@ -24,7 +24,6 @@ type ComponentYAML struct {
 	Subtitle    string                    `yaml:"subtitle"` // Deprecated: use description
 	Input       []*ComponentVariableYAML  `yaml:"input"`
 	Output      *ComponentVariableYAML    `yaml:"output"`
-	Show        string                    `yaml:"show"`
 	Other       map[string]map[string]any `yaml:",inline" mapstructure:",remain"` // Generic renderer: can only have one key
 }
 
@@ -159,7 +158,6 @@ func (p *Parser) parseComponentYAML(tmp *ComponentYAML) (*runtimev1.ComponentSpe
 		RendererProperties: rendererProps,
 		Input:              input,
 		Output:             output,
-		Show:               tmp.Show,
 	}
 
 	return spec, refs, nil

runtime/server/components.go

@@ -3,7 +3,6 @@ package server
 import (
 	"context"
 	"errors"
-	"strconv"
 
 	runtimev1 "github.com/rilldata/rill/proto/gen/rill/runtime/v1"
 	"github.com/rilldata/rill/runtime"
@@ -66,23 +65,6 @@ func (s *Server) ResolveComponent(ctx context.Context, req *runtimev1.ResolveCom
 		},
 	}
 
-	// Resolve templating in the show property
-	if spec.Show != "" {
-		v, err := rillv1.ResolveTemplate(spec.Show, td)
-		if err != nil {
-			return nil, status.Errorf(codes.InvalidArgument, "failed to resolve templating in property \"show\": %s", err.Error())
-		}
-
-		show, err := strconv.ParseBool(v)
-		if err != nil {
-			return nil, status.Errorf(codes.InvalidArgument, "failed to parse value %q as a bool for property \"show\": %s", v, err.Error())
-		}
-
-		if !show {
-			return &runtimev1.ResolveComponentResponse{Show: false}, nil
-		}
-	}
-
 	// Resolve templating in the renderer properties
 	var rendererProps *structpb.Struct
 	if spec.RendererProperties != nil {

web-common/src/proto/gen/rill/runtime/v1/resources_pb.ts

@@ -4303,13 +4303,6 @@ export class ComponentSpec extends Message<ComponentSpec> {
    */
   output?: ComponentVariable;
 
-  /**
-   * Templated string that should evaluate to a boolean.
-   *
-   * @generated from field: string show = 10;
-   */
-  show = "";
-
   /**
    * @generated from field: bool defined_in_canvas = 6;
    */
@@ -4329,7 +4322,6 @@ export class ComponentSpec extends Message<ComponentSpec> {
     { no: 5, name: "renderer_properties", kind: "message", T: Struct },
     { no: 8, name: "input", kind: "message", T: ComponentVariable, repeated: true },
     { no: 9, name: "output", kind: "message", T: ComponentVariable },
-    { no: 10, name: "show", kind: "scalar", T: 9 /* ScalarType.STRING */ },
     { no: 6, name: "defined_in_canvas", kind: "scalar", T: 8 /* ScalarType.BOOL */ },
   ]);
 

web-common/src/runtime-client/gen/index.schemas.ts

@@ -2088,8 +2088,6 @@ export interface V1ComponentSpec {
   rendererProperties?: V1ComponentSpecRendererProperties;
   input?: V1ComponentVariable[];
   output?: V1ComponentVariable;
-  /** Templated string that should evaluate to a boolean. */
-  show?: string;
   definedInCanvas?: boolean;
 }