close response body on error (#5222)

* close response body on error * fix * fix
rilldata · Jul 9, 2024 · 4028b09 · 4028b09
1 parent c81f48e
commit 4028b09
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/runtime/drivers/druid/druidsqldriver/druid_api_sql_driver.go b/runtime/drivers/druid/druidsqldriver/druid_api_sql_driver.go
@@ -74,7 +74,10 @@ func (c *sqlConnection) QueryContext(ctx context.Context, query string, args []d
 		return nil, err
 	}
 
-	if resp.StatusCode != http.StatusOK {
+	// Druid sends well-formed response for 200, 400 and 500 status codes, for others use this
+	// ref - https://druid.apache.org/docs/latest/api-reference/sql-api/#responses
+	if resp.StatusCode != http.StatusOK && resp.StatusCode != http.StatusBadRequest && resp.StatusCode != http.StatusInternalServerError {
+		resp.Body.Close()
 		return nil, fmt.Errorf("unexpected status code: %d, status: %s", resp.StatusCode, resp.Status)
 	}