Skip to content

Commit

Permalink
Admin: fix kind string for iFrame embeds (#4107)
Browse files Browse the repository at this point in the history
  • Loading branch information
pjain1 authored Feb 20, 2024
1 parent 67676e2 commit 669eecd
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion admin/server/deployment.go
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import (
"github.com/rilldata/rill/admin/pkg/urlutil"
"github.com/rilldata/rill/admin/server/auth"
adminv1 "github.com/rilldata/rill/proto/gen/rill/admin/v1"
"github.com/rilldata/rill/runtime"
"github.com/rilldata/rill/runtime/pkg/observability"
runtimeauth "github.com/rilldata/rill/runtime/server/auth"
"go.opentelemetry.io/otel/attribute"
Expand Down Expand Up @@ -352,7 +353,7 @@ func (s *Server) GetIFrame(ctx context.Context, req *adminv1.GetIFrameRequest) (
s.admin.Used.Deployment(prodDepl.ID)

if req.Kind == "" {
req.Kind = "MetricsView"
req.Kind = runtime.ResourceKindMetricsView
}

iFrameURL, err := urlutil.WithQuery(urlutil.MustJoinURL(s.opts.FrontendURL, "/-/embed"), map[string]string{
Expand Down

1 comment on commit 669eecd

@github-actions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.