Support a hidden feature of fax sending

ringcentral · Dec 31, 2019 · ba274ca · ba274ca
1 parent baeec2b
commit ba274ca
Show file tree

Hide file tree

Showing 5 changed files with 47 additions and 6 deletions.
diff --git a/RingCentral.Net/Definitions/CreateFaxMessageRequest.cs b/RingCentral.Net/Definitions/CreateFaxMessageRequest.cs
@@ -16,7 +16,7 @@ public class CreateFaxMessageRequest
         /// <summary>
         /// To Phone Number
         /// </summary>
-        public MessageStoreCallerInfoRequest[] to;
+        public MessageStoreCalleeInfoRequest[] to;
 
         /// <summary>
         /// Timestamp to send fax at. If not specified (current or the past), the fax is sent immediately

diff --git a/RingCentral.Net/Definitions/MessageStoreCalleeInfoRequest.cs b/RingCentral.Net/Definitions/MessageStoreCalleeInfoRequest.cs
@@ -0,0 +1,15 @@
+namespace RingCentral
+{
+    public class MessageStoreCalleeInfoRequest
+    {
+        /// <summary>
+        /// Phone number in E.164 format
+        /// </summary>
+        public string phoneNumber;
+
+        /// <summary>
+        /// Name of the callee
+        /// </summary>
+        public string name;
+    }
+}
diff --git a/RingCentral.Tests/FaxTest.cs b/RingCentral.Tests/FaxTest.cs
@@ -31,9 +31,10 @@ await rc.Authorize(
                 {
                     to = new[]
                     {
-                        new MessageStoreCallerInfoRequest
+                        new MessageStoreCalleeInfoRequest
                         {
                             phoneNumber = Environment.GetEnvironmentVariable("RINGCENTRAL_RECEIVER")
+                            name = "The Receiver"
                         }
                     },
                     attachments = new[]
@@ -78,7 +79,7 @@ await rc.Authorize(
                 {
                     to = new[]
                     {
-                        new MessageStoreCallerInfoRequest
+                        new MessageStoreCalleeInfoRequest
                         {
                             phoneNumber = Environment.GetEnvironmentVariable("RINGCENTRAL_RECEIVER")
                         }
@@ -126,7 +127,7 @@ await rc.Authorize(
                 {
                     to = new[]
                     {
-                        new MessageStoreCallerInfoRequest
+                        new MessageStoreCalleeInfoRequest
                         {
                             phoneNumber = Environment.GetEnvironmentVariable("RINGCENTRAL_RECEIVER")
                         }

diff --git a/code-generator/adjust.js b/code-generator/adjust.js
@@ -19,7 +19,23 @@ faxAttachment.name = 'attachments'
 const faxTo = sendFaxParams.filter(p => p.name === 'to')[0]
 if (faxTo.items.type === 'string') {
   delete faxTo.items.type
-  faxTo.items.$ref = '#/definitions/MessageStoreCallerInfoRequest'
+  faxTo.items.$ref = '#/definitions/MessageStoreCalleeInfoRequest'
+}
+
+// https://jira.ringcentral.com/browse/PLD-337?filter=-2
+// https://github.com/ringcentral/RingCentral.Net/issues/12
+doc.definitions.MessageStoreCalleeInfoRequest = {
+  type: 'object',
+  properties: {
+    phoneNumber: {
+      type: 'string',
+      description: 'Phone number in E.164 format'
+    },
+    name: {
+      type: 'string',
+      description: 'Name of the callee'
+    }
+  }
 }
 
 // https://git.ringcentral.com/platform/api-metadata-specs/issues/48

diff --git a/code-generator/rc-platform-adjusted.yml b/code-generator/rc-platform-adjusted.yml
@@ -1310,7 +1310,7 @@ paths:
           required: true
           type: array
           items:
-            $ref: '#/definitions/MessageStoreCallerInfoRequest'
+            $ref: '#/definitions/MessageStoreCalleeInfoRequest'
         - name: sendTime
           in: formData
           description: >-
@@ -30018,6 +30018,15 @@ definitions:
         example: 8zXq6oaLT7WvwWITlGiA1A
       id_token:
         type: string
+  MessageStoreCalleeInfoRequest:
+    type: object
+    properties:
+      phoneNumber:
+        type: string
+        description: Phone number in E.164 format
+      name:
+        type: string
+        description: Name of the callee
   CustomGreetingAnsweringRuleInfoRequest: &ref_2
     type: object
     properties: