Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly assign null if target is nullable instead of throwing #1191

Merged
merged 1 commit into from
Mar 25, 2024
Merged

fix: correctly assign null if target is nullable instead of throwing #1191

merged 1 commit into from
Mar 25, 2024

Conversation

latonz
Copy link
Contributor

@latonz latonz commented Mar 20, 2024

Closes #1182

@latonz latonz self-assigned this Mar 20, 2024
Copy link

codecov bot commented Mar 20, 2024

Codecov Report

Attention: Patch coverage is 81.81818% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 91.28%. Comparing base (1dcb9b6) to head (0a2dce4).

Files Patch % Lines
...berMappings/MemberNullDelegateAssignmentMapping.cs 71.42% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1191      +/-   ##
==========================================
+ Coverage   91.24%   91.28%   +0.03%     
==========================================
  Files         234      234              
  Lines        8087     8086       -1     
  Branches     1011     1011              
==========================================
+ Hits         7379     7381       +2     
+ Misses        459      456       -3     
  Partials      249      249              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@latonz latonz requested a review from ni507 March 20, 2024 20:09
@latonz latonz enabled auto-merge (squash) March 20, 2024 20:10
@latonz latonz requested a review from ni507 March 21, 2024 20:52
@latonz latonz merged commit f08b7b4 into riok:main Mar 25, 2024
18 of 19 checks passed
@latonz latonz deleted the 1182-null-assignment branch March 25, 2024 06:05
Copy link

🎉 This PR is included in version 3.5.0-next.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ThrowOnPropertyMappingNullMismatch throws an exception for nullable properties
2 participants