Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1470 enum naming strategy #1486

Merged
merged 4 commits into from
Sep 29, 2024
Merged

Conversation

BeeTwin
Copy link
Contributor

@BeeTwin BeeTwin commented Sep 5, 2024

Enum from/to string naming strategies

Description

Added support for enum from/to string naming strategies (PascalCase, snake_case, kebab-case)

Fixes #1470

Checklist

  • The existing code style is followed
  • The commit message follows our guidelines
  • Performed a self-review of my code
  • Hard-to-understand areas of my code are commented
  • The documentation is updated (as applicable)
  • Unit tests are added/updated
  • Integration tests are added/updated (as applicable, especially if feature/bug depends on roslyn or framework version in use)

Copy link
Contributor

@latonz latonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this contribution, I added my feedback 😊

docs/docs/configuration/enum.mdx Outdated Show resolved Hide resolved
docs/docs/configuration/enum.mdx Outdated Show resolved Hide resolved
src/Riok.Mapperly.Abstractions/PublicAPI.Unshipped.txt Outdated Show resolved Hide resolved
src/Riok.Mapperly/Helpers/EnumNamingStrategyHelper.cs Outdated Show resolved Hide resolved
src/Riok.Mapperly/Helpers/EnumNamingStrategyHelper.cs Outdated Show resolved Hide resolved
Copy link
Contributor

@latonz latonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fast updates 😊 I added my feedback. I think a lot will change again with the implementation of #1486 (comment).

src/Riok.Mapperly.Abstractions/MapperAttribute.cs Outdated Show resolved Hide resolved
src/Riok.Mapperly.Abstractions/MapperDefaultsAttribute.cs Outdated Show resolved Hide resolved
docs/docs/configuration/enum.mdx Outdated Show resolved Hide resolved
test/Riok.Mapperly.Tests/Helpers/MemberNamingUtilTests.cs Outdated Show resolved Hide resolved
src/Riok.Mapperly/Helpers/MemberNamingUtil.cs Show resolved Hide resolved
test/Riok.Mapperly.Tests/Helpers/MemberNamingUtilTests.cs Outdated Show resolved Hide resolved
src/Riok.Mapperly/Helpers/MemberNamingUtil.cs Outdated Show resolved Hide resolved
@latonz latonz added the enhancement New feature or request label Sep 8, 2024
@BeeTwin BeeTwin requested a review from latonz September 14, 2024 12:47
@BeeTwin
Copy link
Contributor Author

BeeTwin commented Sep 14, 2024

I still couldn't get the documentation fix to run on my Mac. I tried yarn and npm, but they both are failing.
I hope you can run the fix for me. :)

Copy link
Contributor

@latonz latonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the updates and your patience 😊
I'll fix the linter issues as soon as everything else is ready for merging 👍

@BeeTwin BeeTwin requested a review from latonz September 29, 2024 09:55
latonz
latonz previously approved these changes Sep 29, 2024
@latonz latonz merged commit 5932a4f into riok:main Sep 29, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for mapping enums with different string naming conventions
2 participants