Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace PublicApiAnalyzer with snapshot test #1497

Merged
merged 1 commit into from
Sep 29, 2024

Conversation

latonz
Copy link
Contributor

@latonz latonz commented Sep 18, 2024

Replaces the PublicApiAnalyzer with a snapshot test. This simplifies the handling and detection of public api changes. There is no need to keep separate files for unshipped and shipped apis, no need to move generated api changes from one file to another, and regular c# syntax is used (including syntax highlighting of editors).

@latonz latonz self-assigned this Sep 18, 2024
@latonz latonz added the no-changelog This pull request will be ignored when rendering the changelog label Sep 18, 2024
Replaces the PublicApiAnalyzer with a snapshot test.
This simplifies the handling and detection of public api changes.
There is no need to keep separate files for unshipped and shipped apis,
no need to move generated api changes from one file to another,
and regular c# syntax is used (including syntax highlighting of editors).
@latonz latonz marked this pull request as ready for review September 29, 2024 17:29
@latonz latonz merged commit 6cf2df6 into riok:main Sep 29, 2024
17 checks passed
@latonz latonz deleted the feat/public-api-test branch September 29, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog This pull request will be ignored when rendering the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant